| Summary: | [Metal ANGLE] support primitive restart behavior with simple data types | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Kyle Piddington <kpiddington> | ||||||
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | dino, ews-watchlist, graouts, kondapallykalyan, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Kyle Piddington
2021-04-23 18:07:47 PDT
Created attachment 426970 [details]
Patch
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE Comment on attachment 426970 [details]
Patch
another patch coming, this one has some bugs.
Created attachment 426973 [details]
Patch
Comment on attachment 426973 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=426973&action=review > Source/ThirdParty/ANGLE/ChangeLog:4 > + https://bugs.webkit.org/show_bug.cgi?id=225011 Could you add the radar link in here? > Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/BufferMtl.mm:418 > + T *bufferData = (T*)(idxBuffer->mapReadOnly(ctx)); I'm not sure of ANGLE style, but wouldn't this be better as: auto* bufferData = static_cast<T*>(idxBuffer->mapReadOnly(ctx)); Committed r276569 (237005@main): <https://commits.webkit.org/237005@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 426973 [details]. |