Bug 225011

Summary: [Metal ANGLE] support primitive restart behavior with simple data types
Product: WebKit Reporter: Kyle Piddington <kpiddington>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, ews-watchlist, graouts, kondapallykalyan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Kyle Piddington
Reported 2021-04-23 18:07:47 PDT
[Metal ANGLE] support primitive restart behavior with simple data types
Attachments
Patch (26.50 KB, patch)
2021-04-23 18:11 PDT, Kyle Piddington 		no flags
DetailsFormatted DiffDiff
Patch (26.91 KB, patch)
2021-04-23 19:10 PDT, Kyle Piddington 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kyle Piddington
Comment 1 2021-04-23 18:11:10 PDT
Created attachment 426970 [details] Patch
EWS Watchlist
Comment 2 2021-04-23 18:12:21 PDT
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE
Kyle Piddington
Comment 3 2021-04-23 18:59:02 PDT
Comment on attachment 426970 [details] Patch another patch coming, this one has some bugs.
Kyle Piddington
Comment 4 2021-04-23 19:10:18 PDT
Created attachment 426973 [details] Patch
Dean Jackson
Comment 5 2021-04-25 11:41:08 PDT
Comment on attachment 426973 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=426973&action=review > Source/ThirdParty/ANGLE/ChangeLog:4 > + https://bugs.webkit.org/show_bug.cgi?id=225011 Could you add the radar link in here? > Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/BufferMtl.mm:418 > + T *bufferData = (T*)(idxBuffer->mapReadOnly(ctx)); I'm not sure of ANGLE style, but wouldn't this be better as: auto* bufferData = static_cast<T*>(idxBuffer->mapReadOnly(ctx));
EWS
Comment 6 2021-04-25 12:17:19 PDT
Committed r276569 (237005@main): <https://commits.webkit.org/237005@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 426973 [details].
Radar WebKit Bug Importer
Comment 7 2021-04-25 12:18:16 PDT
<rdar://problem/77125913>
Note You need to log in before you can comment on or make changes to this bug.