Bug 225011 - [Metal ANGLE] support primitive restart behavior with simple data types
Summary: [Metal ANGLE] support primitive restart behavior with simple data types
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-04-23 18:07 PDT by Kyle Piddington
Modified: 2021-04-25 12:18 PDT (History)
5 users (show)

See Also:


Attachments
Patch (26.50 KB, patch)
2021-04-23 18:11 PDT, Kyle Piddington
no flags Details | Formatted Diff | Diff
Patch (26.91 KB, patch)
2021-04-23 19:10 PDT, Kyle Piddington
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle Piddington 2021-04-23 18:07:47 PDT
[Metal ANGLE] support primitive restart behavior with simple data types
Comment 1 Kyle Piddington 2021-04-23 18:11:10 PDT
Created attachment 426970 [details]
Patch
Comment 2 EWS Watchlist 2021-04-23 18:12:21 PDT
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE
Comment 3 Kyle Piddington 2021-04-23 18:59:02 PDT
Comment on attachment 426970 [details]
Patch

another patch coming, this one has some bugs.
Comment 4 Kyle Piddington 2021-04-23 19:10:18 PDT
Created attachment 426973 [details]
Patch
Comment 5 Dean Jackson 2021-04-25 11:41:08 PDT
Comment on attachment 426973 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=426973&action=review

> Source/ThirdParty/ANGLE/ChangeLog:4
> +        https://bugs.webkit.org/show_bug.cgi?id=225011

Could you add the radar link in here?

> Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/BufferMtl.mm:418
> +    T *bufferData = (T*)(idxBuffer->mapReadOnly(ctx));

I'm not sure of ANGLE style, but wouldn't this be better as:

auto* bufferData = static_cast<T*>(idxBuffer->mapReadOnly(ctx));
Comment 6 EWS 2021-04-25 12:17:19 PDT
Committed r276569 (237005@main): <https://commits.webkit.org/237005@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 426973 [details].
Comment 7 Radar WebKit Bug Importer 2021-04-25 12:18:16 PDT
<rdar://problem/77125913>