Summary: | PCM: debug mode should send the second report on a 10 second delay after the first | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kate Cheney <katherine_cheney> | ||||||
Component: | WebKit Misc. | Assignee: | Kate Cheney <katherine_cheney> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | webkit-bug-importer, wilander | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Kate Cheney
2021-04-23 16:52:36 PDT
Created attachment 426968 [details]
Patch
Comment on attachment 426968 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=426968&action=review r=me with small comments. I think it's fine to land this without full EWS feedback since it only affects the opt-in debug mode setting. It could theoretically break regression tests but that is very unlikely. > Source/WebKit/NetworkProcess/PrivateClickMeasurementManager.cpp:401 > + // mode is enabled, this should be every 10 seconds for easy testing. I would avoid stating the 10 seconds since it's a constant that may change, making the comment obsolete. You can say "… this should be much shorter for easy testing." > Source/WebKit/NetworkProcess/PrivateClickMeasurementManager.cpp:413 > + // Or, if debug mode is enabled, we should send the second report on a 10 second delay for easy testing. Ditto. I suggest "… we should send the second report on a much shorter delay for easy testing." Created attachment 426969 [details]
Patch for landing
Committed r276545 (236985@main): <https://commits.webkit.org/236985@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 426969 [details]. |