RESOLVED FIXED 225010
PCM: debug mode should send the second report on a 10 second delay after the first
https://bugs.webkit.org/show_bug.cgi?id=225010
Summary PCM: debug mode should send the second report on a 10 second delay after the ...
Kate Cheney
Reported 2021-04-23 16:52:36 PDT
In PCM debug mode, the first report for an attribution gets sent at the expected 10 seconds. However, the second gets sent at the non-debug mode timing of 24-48 hours. We should fix this.
Attachments
Patch (3.49 KB, patch)
2021-04-23 17:02 PDT, Kate Cheney
no flags
Patch for landing (3.49 KB, patch)
2021-04-23 17:12 PDT, Kate Cheney
no flags
Radar WebKit Bug Importer
Comment 1 2021-04-23 16:52:55 PDT
Kate Cheney
Comment 2 2021-04-23 17:02:22 PDT
John Wilander
Comment 3 2021-04-23 17:07:16 PDT
Comment on attachment 426968 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=426968&action=review r=me with small comments. I think it's fine to land this without full EWS feedback since it only affects the opt-in debug mode setting. It could theoretically break regression tests but that is very unlikely. > Source/WebKit/NetworkProcess/PrivateClickMeasurementManager.cpp:401 > + // mode is enabled, this should be every 10 seconds for easy testing. I would avoid stating the 10 seconds since it's a constant that may change, making the comment obsolete. You can say "… this should be much shorter for easy testing." > Source/WebKit/NetworkProcess/PrivateClickMeasurementManager.cpp:413 > + // Or, if debug mode is enabled, we should send the second report on a 10 second delay for easy testing. Ditto. I suggest "… we should send the second report on a much shorter delay for easy testing."
Kate Cheney
Comment 4 2021-04-23 17:12:44 PDT
Created attachment 426969 [details] Patch for landing
EWS
Comment 5 2021-04-23 17:47:58 PDT
Committed r276545 (236985@main): <https://commits.webkit.org/236985@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 426969 [details].
Note You need to log in before you can comment on or make changes to this bug.