Bug 225010 – PCM: debug mode should send the second report on a 10 second delay after the first

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Kate Cheney]

In PCM debug mode, the first report for an attribution gets sent at the expected 10 seconds. However, the second gets sent at the non-debug mode timing of 24-48 hours. We should fix this.

[Radar WebKit Bug Importer]

<rdar://problem/77092303>

[Kate Cheney]

Created attachment 426968 [details]
Patch

[John Wilander]

Comment on attachment 426968 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=426968&action=review

r=me with small comments. I think it's fine to land this without full EWS feedback since it only affects the opt-in debug mode setting. It could theoretically break regression tests but that is very unlikely.

> Source/WebKit/NetworkProcess/PrivateClickMeasurementManager.cpp:401
> +                    // mode is enabled, this should be every 10 seconds for easy testing.

I would avoid stating the 10 seconds since it's a constant that may change, making the comment obsolete. You can say "… this should be much shorter for easy testing."

> Source/WebKit/NetworkProcess/PrivateClickMeasurementManager.cpp:413
> +                // Or, if debug mode is enabled, we should send the second report on a 10 second delay for easy testing.

Ditto. I suggest "… we should send the second report on a much shorter delay for easy testing."

[Kate Cheney]

Created attachment 426969 [details]
Patch for landing

[EWS]

Committed r276545 (236985@main): <https://commits.webkit.org/236985@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 426969 [details].