Bug 224980

Summary:

REGRESSION (r271861): [iOS] Accessory bar navigation to elements outside the viewport fails

Product:

WebKit

Reporter:

Aditya Keerthi <akeerthi>

Component:

Forms

Assignee:

Aditya Keerthi <akeerthi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, thorton, webkit-bug-importer, wenson_hsieh

Priority:

Keywords:

InRadar

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	wenson_hsieh: review+
Patch for landing	none

Description Aditya Keerthi 2021-04-23 08:59:48 PDT

...

Comment 1 Aditya Keerthi 2021-04-23 09:00:11 PDT

<rdar://problem/77042311>

Comment 2 Aditya Keerthi 2021-04-23 09:09:13 PDT

Created attachment 426913 [details]
Patch

Comment 3 Wenson Hsieh 2021-04-26 08:58:49 PDT

Comment on attachment 426913 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=426913&action=review

> Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:2569
> +    constexpr OptionSet<HitTestRequest::RequestType> hitType { HitTestRequest::ReadOnly, HitTestRequest::Active,  HitTestRequest::AllowChildFrameContent, HitTestRequest::DisallowUserAgentShadowContent, HitTestRequest::IgnoreClipping };

Nit - it looks like this adds an extra leading space before `HitTestRequest::AllowChildFrameContent`.

Comment 4 Aditya Keerthi 2021-04-26 09:07:55 PDT

Created attachment 427054 [details]
Patch for landing

Comment 5 EWS 2021-04-26 10:35:23 PDT

Committed r276598 (237033@main): <https://commits.webkit.org/237033@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 427054 [details].