Bug 224976

Summary: [GStreamer][EME] cbcs fixes
Product: WebKit Reporter: Xabier Rodríguez Calvar <calvaris>
Component: New BugsAssignee: Xabier Rodríguez Calvar <calvaris>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, ews-watchlist, gustavo, menard, pnormand, vjaquez, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Xabier Rodríguez Calvar
Reported 2021-04-23 07:47:11 PDT
[GStreamer][EME] cbcs fixes
Attachments
Patch (2.92 KB, patch)
2021-04-23 07:50 PDT, Xabier Rodríguez Calvar 		no flags
DetailsFormatted DiffDiff
Patch (2.99 KB, patch)
2021-04-23 08:57 PDT, Xabier Rodríguez Calvar 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Xabier Rodríguez Calvar
Comment 1 2021-04-23 07:50:20 PDT
Created attachment 426907 [details] Patch
Philippe Normand
Comment 2 2021-04-23 07:58:22 PDT
Comment on attachment 426907 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=426907&action=review > Source/WebCore/ChangeLog:14 > + cbcs buffers could not include the subsample_count, we conside 0 consider > Source/WebCore/platform/graphics/gstreamer/eme/WebKitCommonEncryptionDecryptorGStreamer.cpp:247 > + unsigned subSampleCount = 0; > + gst_structure_get_uint(protectionMeta->info, "subsample_count", &subSampleCount); Shouldn't this be conditioned on the caps? subsample_count is irrelevant for CBCS but is relevant for the other system.
Xabier Rodríguez Calvar
Comment 3 2021-04-23 08:57:03 PDT
Created attachment 426912 [details] Patch
EWS
Comment 4 2021-04-23 09:31:40 PDT
Committed r276500 (236959@main): <https://commits.webkit.org/236959@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 426912 [details].
Radar WebKit Bug Importer
Comment 5 2021-04-24 15:02:59 PDT
<rdar://problem/77110028>
Note You need to log in before you can comment on or make changes to this bug.