| Summary: | [GStreamer][EME] cbcs fixes | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Xabier Rodríguez Calvar <calvaris> | ||||||
| Component: | New Bugs | Assignee: | Xabier Rodríguez Calvar <calvaris> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | cgarcia, ews-watchlist, gustavo, menard, pnormand, vjaquez, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Xabier Rodríguez Calvar
2021-04-23 07:47:11 PDT
Created attachment 426907 [details]
Patch
Comment on attachment 426907 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=426907&action=review > Source/WebCore/ChangeLog:14 > + cbcs buffers could not include the subsample_count, we conside 0 consider > Source/WebCore/platform/graphics/gstreamer/eme/WebKitCommonEncryptionDecryptorGStreamer.cpp:247 > + unsigned subSampleCount = 0; > + gst_structure_get_uint(protectionMeta->info, "subsample_count", &subSampleCount); Shouldn't this be conditioned on the caps? subsample_count is irrelevant for CBCS but is relevant for the other system. Created attachment 426912 [details]
Patch
Committed r276500 (236959@main): <https://commits.webkit.org/236959@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 426912 [details]. |