Summary: | [css-flexbox] Table layout disregards overriding width | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Felipe Erias <felipeerias> | ||||||
Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bfulgham, changseok, darin, esprehn+autocc, ews-watchlist, glenn, kondapallykalyan, pdr, simon.fraser, svillar, webkit-bug-importer, zalan | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 221473 | ||||||||
Attachments: |
|
Description
Felipe Erias
2021-04-22 08:45:46 PDT
Created attachment 426821 [details]
Patch
Comment on attachment 426821 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=426821&action=review > Source/WebCore/ChangeLog:18 > + Give precedence to the element's overriding width if it has been set, instead of discarding it Super nit: we normally start writing the comment just after the semicolon, so move part of this description to the above line. > Source/WebCore/ChangeLog:20 > + (WebCore::RenderTable::computePreferredLogicalWidths): Ditto. > Source/WebCore/rendering/AutoTableLayout.cpp:287 > + if (tableLogicalWidth.isFixed() && tableLogicalWidth.isPositive()) You can now write this in a single line like this: else if (auto tableLogicalWidth = m_table->style().logicalWidth(); tableLogicalWidth.isFixed() && tableLogicalWidth.isPositive()) Comment on attachment 426821 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=426821&action=review > LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/flex-item-contains-strict-expected.txt:24 > +width expected 0 but got 51 You'd have to modify the GTK's specific expectations for this test, otherwise they'll fail in mac platforms Created attachment 426901 [details]
Patch
Thank you very much for your review! I have updated the patch as suggested. Committed r276572 (237008@main): <https://commits.webkit.org/237008@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 426901 [details]. |