Bug 224897

Summary: Disable GPUProcess on shipping iOS
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cmarcelo, eric.carlson, ews-watchlist, ggaren, glenn, jer.noble, jonlee, kkinnunen, philipj, sabouhallawa, sergio, simon.fraser, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Description Chris Dumez 2021-04-21 14:38:28 PDT 
Disable GPUProcess on shipping iOS due to missing platform support.
Comment 1 Chris Dumez 2021-04-22 09:07:49 PDT 
Created attachment 426818 [details]
Patch
Comment 2 Chris Dumez 2021-04-22 09:11:05 PDT 
Created attachment 426820 [details]
Patch
Comment 3 Tim Horton 2021-04-22 11:13:54 PDT 
Comment on attachment 426820 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=426820&action=review

Why build-time instead of run-time?

> Source/WTF/wtf/PlatformEnableCocoa.h:223
> +#if PLATFORM(MAC) \

I think you still want the !defined() check
Comment 4 Chris Dumez 2021-04-22 11:30:48 PDT 
(In reply to Tim Horton from comment #3)
> Comment on attachment 426820 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=426820&action=review
> 
> Why build-time instead of run-time?

I hesitated. Seems it is not worth building the code on a platform that doesn't support it. Also, if I disabled it by default on a specific platform, it wouldn't prevent someones from explicitly enabling it back in the experimental features.

> 
> > Source/WTF/wtf/PlatformEnableCocoa.h:223
> > +#if PLATFORM(MAC) \
> 
> I think you still want the !defined() check

oh OK.
Comment 5 Chris Dumez 2021-04-22 11:33:13 PDT 
Created attachment 426832 [details]
Patch
Comment 6 Chris Dumez 2021-04-22 17:14:30 PDT 
Created attachment 426871 [details]
Patch
Comment 7 Chris Dumez 2021-04-22 18:14:42 PDT 
Created attachment 426878 [details]
Patch
Comment 8 Chris Dumez 2021-04-22 18:19:47 PDT 
Created attachment 426879 [details]
Patch
Comment 9 Chris Dumez 2021-04-22 18:25:00 PDT 
Created attachment 426880 [details]
Patch
Comment 10 Chris Dumez 2021-04-22 18:28:02 PDT 
Created attachment 426881 [details]
Patch
Comment 11 EWS 2021-04-23 10:44:11 PDT 
Committed r276506 (236963@main): <https://commits.webkit.org/236963@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 426881 [details].
Comment 12 Radar WebKit Bug Importer 2021-04-24 15:02:36 PDT 
<rdar://problem/77110021>