Bug 224873

Summary: [SOUP] Show more connection information in the inspector
Product: WebKit Reporter: Patrick Griffis <pgriffis>
Component: WebKitGTKAssignee: Patrick Griffis <pgriffis>
Status: RESOLVED FIXED    
Severity: Normal CC: aperez, berto, bugs-noreply, cgarcia, ews-watchlist, gustavo
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Patrick Griffis
Reported 2021-04-21 09:09:25 PDT
[SOUP] Show more connection information in the inspector
Attachments
Patch (4.28 KB, patch)
2021-04-21 09:10 PDT, Patrick Griffis 		no flags
DetailsFormatted DiffDiff
Patch (4.19 KB, patch)
2021-04-22 10:31 PDT, Patrick Griffis 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Patrick Griffis
Comment 1 2021-04-21 09:10:44 PDT
Created attachment 426697 [details] Patch
Carlos Garcia Campos
Comment 2 2021-04-22 01:22:27 PDT
Comment on attachment 426697 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=426697&action=review > Source/WebKit/NetworkProcess/soup/NetworkDataTaskSoup.cpp:1032 > + GUniquePtr<char> connectionIdentifier(g_strdup_printf("%" G_GUINT64_FORMAT, soup_message_get_connection_id(m_soupMessage.get()))); > + m_networkLoadMetrics.connectionIdentifier = connectionIdentifier.get(); You could use String::number() and avoid a heap allocation.
Patrick Griffis
Comment 3 2021-04-22 10:31:21 PDT
Created attachment 426828 [details] Patch
EWS
Comment 4 2021-04-22 15:23:46 PDT
Committed r276469 (236929@main): <https://commits.webkit.org/236929@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 426828 [details].
Note You need to log in before you can comment on or make changes to this bug.