Summary: | [SOUP] Show more connection information in the inspector | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Patrick Griffis <pgriffis> | ||||||
Component: | WebKitGTK | Assignee: | Patrick Griffis <pgriffis> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | aperez, berto, bugs-noreply, cgarcia, ews-watchlist, gustavo | ||||||
Priority: | P2 | ||||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Patrick Griffis
2021-04-21 09:09:25 PDT
Created attachment 426697 [details]
Patch
Comment on attachment 426697 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=426697&action=review > Source/WebKit/NetworkProcess/soup/NetworkDataTaskSoup.cpp:1032 > + GUniquePtr<char> connectionIdentifier(g_strdup_printf("%" G_GUINT64_FORMAT, soup_message_get_connection_id(m_soupMessage.get()))); > + m_networkLoadMetrics.connectionIdentifier = connectionIdentifier.get(); You could use String::number() and avoid a heap allocation. Created attachment 426828 [details]
Patch
Committed r276469 (236929@main): <https://commits.webkit.org/236929@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 426828 [details]. |