Bug 224873 - [SOUP] Show more connection information in the inspector
Summary: [SOUP] Show more connection information in the inspector
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Patrick Griffis
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-04-21 09:09 PDT by Patrick Griffis
Modified: 2021-04-22 15:23 PDT (History)
6 users (show)

See Also:


Attachments
Patch (4.28 KB, patch)
2021-04-21 09:10 PDT, Patrick Griffis
no flags Details | Formatted Diff | Diff
Patch (4.19 KB, patch)
2021-04-22 10:31 PDT, Patrick Griffis
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Griffis 2021-04-21 09:09:25 PDT
[SOUP] Show more connection information in the inspector
Comment 1 Patrick Griffis 2021-04-21 09:10:44 PDT
Created attachment 426697 [details]
Patch
Comment 2 Carlos Garcia Campos 2021-04-22 01:22:27 PDT
Comment on attachment 426697 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=426697&action=review

> Source/WebKit/NetworkProcess/soup/NetworkDataTaskSoup.cpp:1032
> +        GUniquePtr<char> connectionIdentifier(g_strdup_printf("%" G_GUINT64_FORMAT, soup_message_get_connection_id(m_soupMessage.get())));
> +        m_networkLoadMetrics.connectionIdentifier = connectionIdentifier.get();

You could use String::number() and avoid a heap allocation.
Comment 3 Patrick Griffis 2021-04-22 10:31:21 PDT
Created attachment 426828 [details]
Patch
Comment 4 EWS 2021-04-22 15:23:46 PDT
Committed r276469 (236929@main): <https://commits.webkit.org/236929@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 426828 [details].