Bug 22487

Summary: Add testcase for FILL_UNSET_PROPERTY macro (and fix crash)
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: CSSAssignee: Chris Marrin <cmarrin>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Attachments:
Description Flags
Testcase
none
Specific test for empty/single-key keyframes
none
Patch, including LayoutTest files mitz: review+

Simon Fraser (smfr)
Reported 2008-11-25 08:53:13 PST
We should add a testcase that exercises the logic in the FILL_UNSET_PROPERTY macro for animations/transitions.
Attachments
Testcase (2.38 KB, text/html)
2008-11-25 08:53 PST, Simon Fraser (smfr) 		no flags
Details
Specific test for empty/single-key keyframes (586 bytes, text/html)
2008-11-25 15:12 PST, Simon Fraser (smfr) 		no flags
Details
Patch, including LayoutTest files (6.69 KB, patch)
2008-11-25 15:49 PST, Chris Marrin 		mitz: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2008-11-25 08:53:38 PST
Created attachment 25483 [details] Testcase Here's the testcase. It currently crashes.
Simon Fraser (smfr)
Comment 2 2008-11-25 08:56:07 PST
Also, I think this testcase should live in LayoutTests/animations, and not css3/
Simon Fraser (smfr)
Comment 3 2008-11-25 15:12:27 PST
Created attachment 25507 [details] Specific test for empty/single-key keyframes
Chris Marrin
Comment 4 2008-11-25 15:49:32 PST
Created attachment 25508 [details] Patch, including LayoutTest files Fix for a null deref bug. I was not checking for 0 length keyframe lists. This patch includes both tests added to this bug.
Simon Fraser (smfr)
Comment 5 2008-11-25 20:53:50 PST
Fixed: http://trac.webkit.org/changeset/38776
Note You need to log in before you can comment on or make changes to this bug.