Bug 22487

Summary: Add testcase for FILL_UNSET_PROPERTY macro (and fix crash)
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: CSSAssignee: Chris Marrin <cmarrin>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Attachments:
Description Flags
Testcase
none
Specific test for empty/single-key keyframes
none
Patch, including LayoutTest files mitz: review+

Description Simon Fraser (smfr) 2008-11-25 08:53:13 PST 
We should add a testcase that exercises the logic in the FILL_UNSET_PROPERTY macro for animations/transitions.
Comment 1 Simon Fraser (smfr) 2008-11-25 08:53:38 PST 
Created attachment 25483 [details]
Testcase

Here's the testcase. It currently crashes.
Comment 2 Simon Fraser (smfr) 2008-11-25 08:56:07 PST 
Also, I think this testcase should live in LayoutTests/animations, and not css3/
Comment 3 Simon Fraser (smfr) 2008-11-25 15:12:27 PST 
Created attachment 25507 [details]
Specific test for empty/single-key keyframes
Comment 4 Chris Marrin 2008-11-25 15:49:32 PST 
Created attachment 25508 [details]
Patch, including LayoutTest files

Fix for a null deref bug. I was not checking for 0 length keyframe lists. This patch includes both tests added to this bug.
Comment 5 Simon Fraser (smfr) 2008-11-25 20:53:50 PST 
Fixed: http://trac.webkit.org/changeset/38776