Bug 224762

Summary: Switch commit-queue back to git.webkit.org
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, jbedard, lingcherd_ho, rniwa, ryanhaddad, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=220479
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
[fast-cq] Patch none

Aakash Jain
Reported 2021-04-19 08:25:29 PDT
We moved all EWS bots from git.webkit.org to github.com in http://trac.webkit.org/r271600. However, since then we have been seeing intermittent failures on commit-queue. We tried various fixes, e.g.: - Added retries in https://commits.webkit.org/r273000 - Added git reset --hard HEAD command in https://commits.webkit.org/r275624 - Added various commands to add robustness in https://commits.webkit.org/r275853 Still, we are noticing issues on commit queue, e.g.: https://ews-build.webkit.org/#/builders/28/builds/11234 Item is out of date: File '/trunk/Source/WebCore/ChangeLog' is out of date https://ews-build.webkit.org/#/builders/28/builds/11227 Item already exists in filesystem: File 'LayoutTests/fast/images/image-extraction/image-overlay-with-selection-styles-expected.html' already exists We should switch Commit-Queue back to git.webkit.org, so as to keep Commit-Queue is a reliably working state. Note that these issues seems related to git-svn, so once WebKit moves to pure git repository, we don't expect these issues, and we can then switch Commit-Queue again to github.
Attachments
Patch (5.03 KB, patch)
2021-04-19 08:30 PDT, Aakash Jain 		no flags
DetailsFormatted DiffDiff
Patch (8.07 KB, patch)
2021-04-20 07:44 PDT, Aakash Jain 		no flags
DetailsFormatted DiffDiff
Patch (12.10 KB, patch)
2021-04-20 08:46 PDT, Aakash Jain 		no flags
DetailsFormatted DiffDiff
[fast-cq] Patch (9.74 KB, patch)
2021-04-20 11:43 PDT, Aakash Jain 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2021-04-19 08:30:32 PDT
Created attachment 426426 [details] Patch
Aakash Jain
Comment 2 2021-04-20 07:44:52 PDT
Created attachment 426545 [details] Patch
Aakash Jain
Comment 3 2021-04-20 08:46:13 PDT
Created attachment 426550 [details] Patch
Jonathan Bedard
Comment 4 2021-04-20 10:01:38 PDT
Comment on attachment 426550 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=426550&action=review > Tools/CISupport/ews-build/steps.py:218 > + self.setCommand(['python', 'Tools/Scripts/git-webkit', '-C', 'https://github.com/WebKit/Webkit', 'find', revision]) What is "revision" expected to be? Because if it is an actual subversion revision, this won't work. If it's an identifier or hash, this will work
Aakash Jain
Comment 5 2021-04-20 10:37:55 PDT
Comment on attachment 426550 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=426550&action=review >> Tools/CISupport/ews-build/steps.py:218 >> + self.setCommand(['python', 'Tools/Scripts/git-webkit', '-C', 'https://github.com/WebKit/Webkit', 'find', revision]) > > What is "revision" expected to be? Because if it is an actual subversion revision, this won't work. If it's an identifier or hash, this will work it's git hash.
Aakash Jain
Comment 6 2021-04-20 11:43:46 PDT
Created attachment 426576 [details] [fast-cq] Patch
EWS
Comment 7 2021-04-20 12:29:50 PDT
Committed r276315 (236796@main): <https://commits.webkit.org/236796@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 426576 [details].
Aakash Jain
Comment 8 2021-04-20 12:35:31 PDT
Tested in https://ews-build.webkit-uat.org/#/builders/26/builds/2069
Ling Ho
Comment 9 2021-04-23 02:47:15 PDT
rdar://76911197
Aakash Jain
Comment 10 2021-04-28 07:28:42 PDT
Commit-Queue seems to be working very reliably since the transition to git.webkit.org.
Note You need to log in before you can comment on or make changes to this bug.