| Summary: | Add memory allocation checks in more realtime audio capture/rendering places | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||||||||||
| Component: | WebRTC | Assignee: | youenn fablet <youennf> | ||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||
| Severity: | Normal | CC: | eric.carlson, ews-watchlist, glenn, hta, jer.noble, philipj, sergio, tommyw, webkit-bug-importer, youennf | ||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||
| Version: | WebKit Local Build | ||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||
| OS: | Unspecified | ||||||||||||||||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=225196 https://bugs.webkit.org/show_bug.cgi?id=225204 https://bugs.webkit.org/show_bug.cgi?id=225374 |
||||||||||||||||
| Attachments: |
|
||||||||||||||||
|
Description
youenn fablet
2021-04-19 05:09:14 PDT
Created attachment 426412 [details]
Patch
Created attachment 426427 [details]
Patch
Created attachment 426429 [details]
Patch
Created attachment 426657 [details]
Patch
Created attachment 426679 [details]
Patch
Comment on attachment 426679 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=426679&action=review > Source/WebCore/platform/mediastream/mac/RealtimeIncomingAudioSourceCocoa.h:60 > + static constexpr size_t ChunksReceivedDelta = 200; // 200 chunks of 10ms = 2s. I had to look at the source to understand what this constant is for, maybe "LogAfterChunksRecieved" or "ChunksRecievedLogCount"? Created attachment 427050 [details]
Patch for landing
Committed r276633 (237061@main): <https://commits.webkit.org/237061@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 427050 [details]. |