Bug 224750

Summary: Add memory allocation checks in more realtime audio capture/rendering places
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, ews-watchlist, glenn, hta, jer.noble, philipj, sergio, tommyw, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=225196
https://bugs.webkit.org/show_bug.cgi?id=225204
https://bugs.webkit.org/show_bug.cgi?id=225374
Attachments:
Description Flags
Patch
none
Patch
ews-feeder: commit-queue-
Patch
none
Patch
none
Patch
none
Patch for landing none

youenn fablet
Reported 2021-04-19 05:09:14 PDT
Add memory allocation checks in more realtime audio capture/rendering places
Attachments
Patch (20.38 KB, patch)
2021-04-19 06:15 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (18.09 KB, patch)
2021-04-19 08:57 PDT, youenn fablet 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (20.32 KB, patch)
2021-04-19 09:05 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (20.98 KB, patch)
2021-04-21 00:50 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (21.33 KB, patch)
2021-04-21 07:12 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (21.33 KB, patch)
2021-04-26 08:33 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2021-04-19 06:15:17 PDT
Created attachment 426412 [details] Patch
youenn fablet
Comment 2 2021-04-19 08:57:54 PDT
Created attachment 426427 [details] Patch
youenn fablet
Comment 3 2021-04-19 09:05:05 PDT
Created attachment 426429 [details] Patch
youenn fablet
Comment 4 2021-04-21 00:50:49 PDT
Created attachment 426657 [details] Patch
youenn fablet
Comment 5 2021-04-21 07:12:43 PDT
Created attachment 426679 [details] Patch
Eric Carlson
Comment 6 2021-04-21 10:00:47 PDT
Comment on attachment 426679 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=426679&action=review > Source/WebCore/platform/mediastream/mac/RealtimeIncomingAudioSourceCocoa.h:60 > + static constexpr size_t ChunksReceivedDelta = 200; // 200 chunks of 10ms = 2s. I had to look at the source to understand what this constant is for, maybe "LogAfterChunksRecieved" or "ChunksRecievedLogCount"?
Radar WebKit Bug Importer
Comment 7 2021-04-26 05:10:16 PDT
<rdar://problem/77148592>
youenn fablet
Comment 8 2021-04-26 08:33:47 PDT
Created attachment 427050 [details] Patch for landing
EWS
Comment 9 2021-04-27 03:04:28 PDT
Committed r276633 (237061@main): <https://commits.webkit.org/237061@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 427050 [details].
Note You need to log in before you can comment on or make changes to this bug.