Bug 224729

Summary: [JSC] Use FixedVector for LLIntPrototypeLoadAdaptiveStructureWatchpoint vector
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, ews-watchlist, keith_miller, lingcherd_ho, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch darin: review+

Yusuke Suzuki
Reported 2021-04-18 01:41:47 PDT
[JSC] Use FixedVector for LLIntPrototypeLoadAdaptiveStructureWatchpoint vector
Attachments
Patch (5.39 KB, patch)
2021-04-18 01:42 PDT, Yusuke Suzuki 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2021-04-18 01:42:09 PDT
Created attachment 426374 [details] Patch
Darin Adler
Comment 2 2021-04-18 14:02:23 PDT
Comment on attachment 426374 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=426374&action=review > Source/JavaScriptCore/bytecode/LLIntPrototypeLoadAdaptiveStructureWatchpoint.cpp:48 > + : Watchpoint(Watchpoint::Type::LLIntPrototypeLoadAdaptiveStructure) > + , m_owner(nullptr) > + , m_bytecodeOffset(0) Can we initialize some or all of these in the class definition instead of in the constructor? I guess not because of JSC_WATCHPOINT_FIELD.
Yusuke Suzuki
Comment 3 2021-04-20 00:23:53 PDT
Comment on attachment 426374 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=426374&action=review >> Source/JavaScriptCore/bytecode/LLIntPrototypeLoadAdaptiveStructureWatchpoint.cpp:48 >> + , m_bytecodeOffset(0) > > Can we initialize some or all of these in the class definition instead of in the constructor? I guess not because of JSC_WATCHPOINT_FIELD. Yes, we cannot do that.
Yusuke Suzuki
Comment 4 2021-04-20 00:26:20 PDT
Committed r276290 (236772@main): <https://commits.webkit.org/236772@main>
Ling Ho
Comment 5 2021-04-23 02:55:50 PDT
rdar://76884672
Note You need to log in before you can comment on or make changes to this bug.