| Summary: | [JSC] Use FixedVector for LLIntPrototypeLoadAdaptiveStructureWatchpoint vector | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Yusuke Suzuki <ysuzuki> | ||||
| Component: | New Bugs | Assignee: | Yusuke Suzuki <ysuzuki> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | darin, ews-watchlist, keith_miller, lingcherd_ho, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Yusuke Suzuki
2021-04-18 01:41:47 PDT
Created attachment 426374 [details]
Patch
Comment on attachment 426374 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=426374&action=review > Source/JavaScriptCore/bytecode/LLIntPrototypeLoadAdaptiveStructureWatchpoint.cpp:48 > + : Watchpoint(Watchpoint::Type::LLIntPrototypeLoadAdaptiveStructure) > + , m_owner(nullptr) > + , m_bytecodeOffset(0) Can we initialize some or all of these in the class definition instead of in the constructor? I guess not because of JSC_WATCHPOINT_FIELD. Comment on attachment 426374 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=426374&action=review >> Source/JavaScriptCore/bytecode/LLIntPrototypeLoadAdaptiveStructureWatchpoint.cpp:48 >> + , m_bytecodeOffset(0) > > Can we initialize some or all of these in the class definition instead of in the constructor? I guess not because of JSC_WATCHPOINT_FIELD. Yes, we cannot do that. Committed r276290 (236772@main): <https://commits.webkit.org/236772@main> |