Summary: | REGRESSION(r276164) [GTK] WKPreferencesDefaults API test is failing | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Lauro Moura <lmoura> | ||||
Component: | New Bugs | Assignee: | Lauro Moura <lmoura> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | achristensen, bugs-noreply, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=224629 | ||||||
Attachments: |
|
Description
Lauro Moura
2021-04-16 20:35:50 PDT
Created attachment 426317 [details]
Patch
Comment on attachment 426317 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=426317&action=review > Tools/TestWebKitAPI/Tests/WebKit/WKPreferences.cpp:-77 > - EXPECT_FALSE(WKPreferencesGetOfflineWebApplicationCacheEnabled(preference)); Ah, yes. I was wondering how I changed behavior, but I actually just changed the expectations to match the Cocoa expectations. This changes the expectations back. As mentioned in the original bug, you should probably have a discussion of how/when you want to disable it. Committed r276195 (236677@main): <https://commits.webkit.org/236677@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 426317 [details]. |