Bug 224710

Summary: REGRESSION(r276164) [GTK] WKPreferencesDefaults API test is failing
Product: WebKit Reporter: Lauro Moura <lmoura>
Component: New BugsAssignee: Lauro Moura <lmoura>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bugs-noreply, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=224629
Attachments:
Description Flags
Patch none

Lauro Moura
Reported 2021-04-16 20:35:50 PDT
REGRESSION(r276164) [GTK] WKPreferencesDefaults API test is failing
Attachments
Patch (4.16 KB, patch)
2021-04-16 20:36 PDT, Lauro Moura 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Lauro Moura
Comment 1 2021-04-16 20:36:38 PDT
Created attachment 426317 [details] Patch
Alex Christensen
Comment 2 2021-04-16 21:01:19 PDT
Comment on attachment 426317 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=426317&action=review > Tools/TestWebKitAPI/Tests/WebKit/WKPreferences.cpp:-77 > - EXPECT_FALSE(WKPreferencesGetOfflineWebApplicationCacheEnabled(preference)); Ah, yes. I was wondering how I changed behavior, but I actually just changed the expectations to match the Cocoa expectations. This changes the expectations back. As mentioned in the original bug, you should probably have a discussion of how/when you want to disable it.
EWS
Comment 3 2021-04-16 22:04:07 PDT
Committed r276195 (236677@main): <https://commits.webkit.org/236677@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 426317 [details].
Radar WebKit Bug Importer
Comment 4 2021-04-24 15:08:17 PDT
<rdar://problem/77110106>
Note You need to log in before you can comment on or make changes to this bug.