Bug 22470

Summary: remove unneeded URL argument from FrameLoaderClient::updateGlobalHistory
Product: WebKit Reporter: Darin Adler <darin>
Component: Page LoadingAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Attachments:
Description Flags
patch mitz: review+

Description Darin Adler 2008-11-24 15:18:46 PST 
Looking at implementations of updateGlobalHistory, Qt is the only platform that uses the passed-in URL without also getting other data from the DocumentLoader. The Mac and Win platforms both get things like the page title from the DocumentLoader, and so they could just have easily gotten the URL that way too. I think that historically the URL was harder to get, but now there's the simple urlForHistory function that gives you just the right URL.

So I want to remove this argument.
Comment 1 Darin Adler 2008-11-24 15:22:58 PST 
Created attachment 25455 [details]
patch
Comment 2 Darin Adler 2008-11-24 15:32:47 PST 
http://trac.webkit.org/changeset/38732