Bug 224682

Summary:

Remove redundant renderObject in BreakingContext::handleText

Product:

WebKit

Reporter:

zalan <zalan>

Component:

Layout and Rendering

Assignee:

zalan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, changseok, darin, esprehn+autocc, ews-watchlist, glenn, kondapallykalyan, pdr, simon.fraser, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Description zalan 2021-04-16 11:00:42 PDT

ssia

Comment 1 zalan 2021-04-16 11:02:17 PDT

Created attachment 426247 [details]
Patch

Comment 2 Darin Adler 2021-04-16 11:04:40 PDT

Comment on attachment 426247 [details]
Patch

I would name this local variable "renderer". Sure, its type is RenderText&, but the role of the object is "the renderer for the text we are handling".

Comment 3 zalan 2021-04-16 11:07:18 PDT

(In reply to Darin Adler from comment #2)
> Comment on attachment 426247 [details]
> Patch
> 
> I would name this local variable "renderer". Sure, its type is RenderText&,
> but the role of the object is "the renderer for the text we are handling".
ok

Comment 4 zalan 2021-04-16 11:12:44 PDT

Created attachment 426249 [details]
Patch

Comment 5 EWS 2021-04-16 14:13:19 PDT

Committed r276169 (236656@main): <https://commits.webkit.org/236656@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 426249 [details].

Comment 6 Radar WebKit Bug Importer 2021-04-24 15:08:43 PDT

<rdar://problem/77110114>