Bug 224682

Summary: Remove redundant renderObject in BreakingContext::handleText
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, changseok, darin, esprehn+autocc, ews-watchlist, glenn, kondapallykalyan, pdr, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

alan
Reported 2021-04-16 11:00:42 PDT
ssia
Attachments
Patch (4.63 KB, patch)
2021-04-16 11:02 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (21.55 KB, patch)
2021-04-16 11:12 PDT, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2021-04-16 11:02:17 PDT
Created attachment 426247 [details] Patch
Darin Adler
Comment 2 2021-04-16 11:04:40 PDT
Comment on attachment 426247 [details] Patch I would name this local variable "renderer". Sure, its type is RenderText&, but the role of the object is "the renderer for the text we are handling".
alan
Comment 3 2021-04-16 11:07:18 PDT
(In reply to Darin Adler from comment #2) > Comment on attachment 426247 [details] > Patch > > I would name this local variable "renderer". Sure, its type is RenderText&, > but the role of the object is "the renderer for the text we are handling". ok
alan
Comment 4 2021-04-16 11:12:44 PDT
Created attachment 426249 [details] Patch
EWS
Comment 5 2021-04-16 14:13:19 PDT
Committed r276169 (236656@main): <https://commits.webkit.org/236656@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 426249 [details].
Radar WebKit Bug Importer
Comment 6 2021-04-24 15:08:43 PDT
<rdar://problem/77110114>
Note You need to log in before you can comment on or make changes to this bug.