Bug 224665

Summary: [css-flexbox] Table layout disregards overriding height
Product: WebKit Reporter: Felipe Erias <felipeerias>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, changseok, esprehn+autocc, ews-watchlist, felipeerias, glenn, kondapallykalyan, pdr, simon.fraser, svillar, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 221473    
Attachments:
Description Flags
Patch
none
Patch none

Felipe Erias
Reported 2021-04-16 05:34:54 PDT
These two WPT tests fail because the overriding height set by the table's flex parent is being ignored: imported/w3c/web-platform-tests/css/css-flexbox/table-as-item-flex-cross-size.html imported/w3c/web-platform-tests/css/css-flexbox/table-as-item-stretch-cross-size.html
Attachments
Patch (4.47 KB, patch)
2021-04-16 06:07 PDT, Felipe Erias 		no flags
DetailsFormatted DiffDiff
Patch (4.89 KB, patch)
2021-04-18 23:35 PDT, Felipe Erias 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Felipe Erias
Comment 1 2021-04-16 06:07:52 PDT
Created attachment 426213 [details] Patch
Sergio Villar Senin
Comment 2 2021-04-16 08:08:49 PDT
Comment on attachment 426213 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=426213&action=review Looks good to me. I wonder, does it not fix any grid-layout width tables bug? > Source/WebCore/ChangeLog:3 > + Table layout takes overriding height into account This is a nit, but bug title normally describes the issue and... > Source/WebCore/ChangeLog:8 > + RenderTable::layout applies the overriding height set by the element's parent. ChangeLog body describes the fix. Don't be afraid to be verbose :)
Felipe Erias
Comment 3 2021-04-18 23:35:41 PDT
Created attachment 426396 [details] Patch
EWS
Comment 4 2021-04-19 01:39:11 PDT
Committed r276240 (236722@main): <https://commits.webkit.org/236722@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 426396 [details].
Radar WebKit Bug Importer
Comment 5 2021-04-24 15:05:36 PDT
<rdar://problem/77110064>
Note You need to log in before you can comment on or make changes to this bug.