Bug 22465 – Define KURL::copy() and use it in WorkerThread.cpp

• Component: Platform
• Status: RESOLVED FIXED

[Darin Fisher (:fishd, Google)]

Define KURL::copy() and use it in WorkerThread.cpp

It would be handy to have a "deep copy" function on KURL to avoid re-parsing when passing a KURL to a background thread.

[Darin Fisher (:fishd, Google)]

Created attachment 25456 [details]
v1 patch

[Geoffrey Garen]

Comment on attachment 25456 [details]
v1 patch

"deepCopy" might be a better name for conveying that you shouldn't call this function if you don't mean it. Then you can remove this part of you comment, too:

// Makes a deep copy.

r=me

[Adam Barth]

There is some value in being consistent with other classes.  Should we change SecurityOrigin::copy to be deepCopy as well?

[Darin Fisher (:fishd, Google)]

What about String::copy()?  I was just replicating that.  Notice that my comments are very similar to the comments above String::copy()!  Should we change them all?

[Darin Fisher (:fishd, Google)]

http://trac.webkit.org/changeset/38746

Per discussion on #webkit, I'm going to file a follow-up bug to consider renaming all of these 'copy' methods to 'deepCopy'.

[Darin Fisher (:fishd, Google)]

Please see https://bugs.webkit.org/show_bug.cgi?id=22479 for the follow-up bug.