Bug 224649

Summary: WebCoreArgumentCoders.h: error: 'WebCore/MediaPlaybackTargetContext.h' file not found since r276107
Product: WebKit Reporter: Fujii Hironori <Hironori.Fujii>
Component: MediaAssignee: Fujii Hironori <Hironori.Fujii>
Status: RESOLVED INVALID    
Severity: Normal CC: peng.liu6
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 224469    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Fujii Hironori
Reported 2021-04-15 23:15:00 PDT
WebCoreArgumentCoders.h: error: 'WebCore/MediaPlaybackTargetContext.h' file not found since r276107 r276107 (236607@main) > [4971/5700] Building CXX object Source\WebKit\CMakeFiles\WebKit.dir\__\__\WebKit\DerivedSources\RemoteMediaPlayerProxyMessageReceiver.cpp.obj > FAILED: Source/WebKit/CMakeFiles/WebKit.dir/__/__/WebKit/DerivedSources/RemoteMediaPlayerProxyMessageReceiver.cpp.obj > C:\PROGRA~1\LLVM\bin\clang-cl.exe (...) -c WebKit\DerivedSources\RemoteMediaPlayerProxyMessageReceiver.cpp > In file included from WebKit\DerivedSources\RemoteMediaPlayerProxyMessageReceiver.cpp:46: > ..\..\Source\WebKit\Shared\WebCoreArgumentCoders.h(36,10): fatal error: 'WebCore/MediaPlaybackTargetContext.h' file not found > #include <WebCore/MediaPlaybackTargetContext.h> > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > 1 error generated.
Attachments
Patch (1.64 KB, patch)
2021-04-15 23:17 PDT, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Fujii Hironori
Comment 1 2021-04-15 23:17:24 PDT
Created attachment 426186 [details] Patch
Peng Liu
Comment 2 2021-04-15 23:25:24 PDT
Thanks for the fix!
Fujii Hironori
Comment 3 2021-04-15 23:33:34 PDT
This fix isn't enough. More errors. WebKitBuild\Debug\WebKit\DerivedSources\WebPageProxyMessages.h(65): fatal error C1083: Cannot open include file: 'WebCore/MediaPlaybackTargetContext.h': No such file or directory
Fujii Hironori
Comment 4 2021-04-15 23:43:08 PDT
Umm, <WebCore/MediaPlaybackTargetContext.h> is included from the derived source. Can I revert your r276107?
Fujii Hironori
Comment 5 2021-04-15 23:56:34 PDT
I'm sorry. It isn't easy to fix the build error. r276120 reverted your r276107. It broke only clean builds. Feel free to ask me try clean builds if you need.
Peng Liu
Comment 6 2021-04-16 01:10:33 PDT
Does it break windows port only?
Note You need to log in before you can comment on or make changes to this bug.