Summary: | Use kIOMainPortDefault where available | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||||||
Component: | New Bugs | Assignee: | Alex Christensen <achristensen> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | ap, dino, ews-watchlist, graouts, kkinnunen, kondapallykalyan, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Alex Christensen
2021-04-15 16:53:26 PDT
Created attachment 426157 [details]
Patch
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE Created attachment 426165 [details]
Patch
Created attachment 426166 [details]
Patch
Comment on attachment 426166 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=426166&action=review I would probably centralize this in one place if I were doing this, but seems OK either way. > Source/ThirdParty/ANGLE/src/gpu_info_util/SystemInfo_macos.mm:41 > #pragma clang diagnostic ignored "-Wdeprecated-declarations" You can consider adding comments saying that the pragmas can be removed once rdar://76706593 is fixed, but it's not terribly important. Committed r276104 (236604@main): <https://commits.webkit.org/236604@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 426166 [details]. Not sure if I'm doing something wrong, but I'm seeing the inverse issue now with an older SDK. CompileC SystemInfo_macos.o /Users/kkinnunen/WebKit/OpenSource/Source/ThirdParty/ANGLE/src/gpu_info_util/SystemInfo_macos.mm:38:34: error: use of undeclared identifier 'kIOMainPortDefault' const mach_port_t mainPort = kIOMainPortDefault; ^ /Users/kkinnunen/WebKit/OpenSource/Source/ThirdParty/ANGLE/src/gpu_info_util/SystemInfo_macos.mm:109:38: error: use of undeclared identifier 'kIOMainPortDefault' const mach_port_t mainPort = kIOMainPortDefault; ^ /Users/kkinnunen/WebKit/OpenSource/Source/ThirdParty/ANGLE/src/gpu_info_util/SystemInfo_macos.mm:176:34: error: use of undeclared identifier 'kIOMainPortDefault' const mach_port_t mainPort = kIOMainPortDefault; ^ /Users/kkinnunen/WebKit/OpenSource/Source/ThirdParty/ANGLE/src/gpu_info_util/SystemInfo_macos.mm:285:38: error: use of undeclared identifier 'kIOMainPortDefault' const mach_port_t mainPort = kIOMainPortDefault; ^ (In reply to Kimmo Kinnunen from comment #7) > Not sure if I'm doing something wrong, but I'm seeing the inverse issue now > with an older SDK. Time to update your SDK. |