Bug 224630

Summary: [PlayStation][OpenSSL] Remove warnings.
Product: WebKit Reporter: Basuke Suzuki <basuke>
Component: PlatformAssignee: Basuke Suzuki <basuke>
Status: RESOLVED FIXED    
Severity: Normal CC: basuke, don.olmstead, ews-watchlist, jiewen_tan, stephan.szabo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
PATCH
ews-feeder: commit-queue-
PATCH none

Basuke Suzuki
Reported 2021-04-15 16:23:17 PDT
There're two kinds of warnings in curl and openssl layer in our platform. a) Unused param b) '__WORDSIZE' is not defined. [2530/5050] Building CXX object Source/WebCore/CM...es/unified-sources/UnifiedSource-44a97133-1.cpp.oIn file included from WebCore/DerivedSources/unified-sources/UnifiedSource-44a97133-1.cpp:8: ../../Source/WebCore\crypto/algorithms/CryptoAlgorithmAES_GCM.cpp:42:5: warning: '__WORDSIZE' is not defined, evaluates to 0 [-Wundef] #if __WORDSIZE >= 64 ^ ../../Source/WebCore\crypto/algorithms/CryptoAlgorithmAES_GCM.cpp:80:5: warning: '__WORDSIZE' is not defined, evaluates to 0 [-Wundef] #if __WORDSIZE >= 64 ^ ../../Source/WebCore\crypto/algorithms/CryptoAlgorithmAES_GCM.cpp:123:5: warning: '__WORDSIZE' is not defined, evaluates to 0 [-Wundef] #if __WORDSIZE >= 64 ^ 3 warnings generated.
Attachments
PATCH (7.28 KB, patch)
2021-04-15 17:30 PDT, Basuke Suzuki 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
PATCH (7.28 KB, patch)
2021-04-15 18:50 PDT, Basuke Suzuki 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Basuke Suzuki
Comment 1 2021-04-15 17:30:01 PDT
Created attachment 426159 [details] PATCH
Stephan Szabo
Comment 2 2021-04-15 18:01:06 PDT
Comment on attachment 426159 [details] PATCH View in context: https://bugs.webkit.org/attachment.cgi?id=426159&action=review > Source/WebCore/crypto/openssl/CryptoKeyRSAOpenSSL.cpp:36 > +RefPtr<CryptoKeyRSA> CryptoKeyRSA::create(CryptoAlgorithmIdentifier, CryptoAlgorithmIdentifier, bool hasHash, const CryptoKeyRSAComponents&, bool extractable, CryptoKeyUsageBitmap) Is there a reason to remove just one argument's name here and then use UNUSED_PARAM for the others arguments? It seems like it'd be better to be consistent.
Basuke Suzuki
Comment 3 2021-04-15 18:50:10 PDT
Created attachment 426169 [details] PATCH
Basuke Suzuki
Comment 4 2021-04-15 18:52:12 PDT
Comment on attachment 426159 [details] PATCH View in context: https://bugs.webkit.org/attachment.cgi?id=426159&action=review >> Source/WebCore/crypto/openssl/CryptoKeyRSAOpenSSL.cpp:36 >> +RefPtr<CryptoKeyRSA> CryptoKeyRSA::create(CryptoAlgorithmIdentifier, CryptoAlgorithmIdentifier, bool hasHash, const CryptoKeyRSAComponents&, bool extractable, CryptoKeyUsageBitmap) > > Is there a reason to remove just one argument's name here and then use UNUSED_PARAM for the others arguments? It seems like it'd be better to be consistent. I follow style guideline that if the argument is described enough by type, then it should be omitted if possible. On the other hand, bool, int or such general type is not.
Stephan Szabo
Comment 5 2021-04-15 18:59:11 PDT
(In reply to Basuke Suzuki from comment #4) > Comment on attachment 426159 [details] > PATCH > > I follow style guideline that if the argument is described enough by type, > then it should be omitted if possible. On the other hand, bool, int or such > general type is not. Okay, that seems like a reasonable division. :)
EWS
Comment 6 2021-04-16 14:07:37 PDT
Committed r276167 (236654@main): <https://commits.webkit.org/236654@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 426169 [details].
Radar WebKit Bug Importer
Comment 7 2021-04-24 15:08:50 PDT
<rdar://problem/77110115>
Note You need to log in before you can comment on or make changes to this bug.