Bug 224620

Summary:

webkitpy classes need not define loads/dumps helpers for pickle

Product:

WebKit

Reporter:

Sam Sneddon [:gsnedders] <gsnedders>

Component:

Tools / Tests

Assignee:

Sam Sneddon [:gsnedders] <gsnedders>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ews-watchlist, glenn, jbedard, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Sam Sneddon [:gsnedders] 2021-04-15 13:34:41 PDT

These have little advantage versus calling pickle directly (and lack some of the options), and are only used by the tests to ensure certain classes round-trip.

Comment 1 Sam Sneddon [:gsnedders] 2021-04-15 13:37:51 PDT

Created attachment 426132 [details]
Patch

Comment 2 EWS 2021-04-15 15:44:37 PDT

Committed r276081 (236593@main): <https://commits.webkit.org/236593@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 426132 [details].

Comment 3 Ryan Haddad 2021-04-15 15:59:38 PDT

rdar://76727229