Bug 224592

Summary:

Add missing exception check in operationGetPrivateNameOptimize().

Product:

WebKit

Reporter:

Mark Lam <mark.lam>

Component:

JavaScriptCore

Assignee:

Mark Lam <mark.lam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ews-watchlist, keith_miller, msaboff, saam, tzagallo, webkit-bug-importer, ysuzuki

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
proposed patch.	ysuzuki: review+

Description Mark Lam 2021-04-14 22:29:23 PDT

rdar://76645873

Comment 1 Mark Lam 2021-04-14 22:39:01 PDT

Created attachment 426075 [details]
proposed patch.

Comment 2 Yusuke Suzuki 2021-04-14 22:45:48 PDT

Comment on attachment 426075 [details]
proposed patch.

r=me

Comment 3 Yusuke Suzuki 2021-04-14 22:46:12 PDT

Comment on attachment 426075 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=426075&action=review

> Source/JavaScriptCore/jit/JITOperations.cpp:2407
> +        EXCEPTION_ASSERT(!scope.exception() || vm.isTerminationException(scope.exception()));

We discussed and left this assertion for documentation purpose.

Comment 4 Mark Lam 2021-04-14 22:54:28 PDT

Thanks for the review.  Landed in r276000: <http://trac.webkit.org/r276000>.