Bug 22458

Summary:

[wx] wxWebView lacks a "find string" API

Product:

WebKit

Reporter:

Kevin Watters <kevinwatters>

Component:

WebKit wx

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

All

Attachments:

Description	Flags
implements wxWebView::FindString	kevino: review-
fixed wxWebView::FindString patch	kevino: review+

Kevin Watters

Reported 2008-11-24 11:08:09 PST

There is no simple API to find strings in a wxWebView.

Attachments
implements wxWebView::FindString (1.56 KB, patch) 2008-11-24 11:08 PST, Kevin Watters	kevino: review-	Details Formatted Diff Diff
fixed wxWebView::FindString patch (2.73 KB, patch) 2008-12-02 15:20 PST, Kevin Watters	kevino: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Kevin Watters

Comment 1 2008-11-24 11:08:46 PST

Created attachment 25436 [details] implements wxWebView::FindString

Kevin Ollivier

Comment 2 2008-12-02 09:40:29 PST

r- because this patch only works with the wxWebView's main frame. Even though we don't currently support multiple frames, we're close to having that implemented, and so I would like all new functionality that calls frame methods to go in wxWebFrame rather than wxWebView.

Kevin Watters

Comment 3 2008-12-02 15:20:05 PST

Created attachment 25688 [details] fixed wxWebView::FindString patch Implements wxWebFrame::FindString. Places frame functionality in wxWebFrame, not wxWebView.

Kevin Ollivier

Comment 4 2008-12-13 09:51:32 PST

Landed in r39273, thanks!

Note You need to log in before you can comment on or make changes to this bug.