Bug 224572

Summary: Apply DeferTermination in some utility functions in the jsc shell.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, msaboff, saam, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch. ysuzuki: review+, ews-feeder: commit-queue-

Mark Lam
Reported 2021-04-14 12:44:16 PDT
This is to make sure that these functions don't get in the way of testing with the watchdog. Since these are only test utility functions, just doing the simple thing of using a DeferTermination scope is the right thing to do here.
Attachments
proposed patch. (1.82 KB, patch)
2021-04-14 13:47 PDT, Mark Lam 		ysuzuki: review+
ews-feeder: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2021-04-14 12:44:43 PDT
rdar://76646089
Mark Lam
Comment 2 2021-04-14 13:47:59 PDT
Created attachment 426042 [details] proposed patch.
Yusuke Suzuki
Comment 3 2021-04-14 13:50:15 PDT
Comment on attachment 426042 [details] proposed patch. r=me
Mark Lam
Comment 4 2021-04-14 13:52:19 PDT
Comment on attachment 426042 [details] proposed patch. Thanks for the review.
Mark Lam
Comment 5 2021-04-14 14:52:50 PDT
Closed the wrong bug: too many browser tabs going at the same time. Sorry.
Mark Lam
Comment 6 2021-04-14 14:58:20 PDT
I added the comment in the description above in the ChangeLog before landing. Landed in r275971: <http://trac.webkit.org/r275971>.
Note You need to log in before you can comment on or make changes to this bug.