Summary: | Store whether a test is slow on TestInput | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Sam Sneddon [:gsnedders] <gsnedders> | ||||||
Component: | Tools / Tests | Assignee: | Sam Sneddon [:gsnedders] <gsnedders> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | ap, ews-watchlist, glenn, jbedard, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=161626 | ||||||||
Attachments: |
|
Description
Sam Sneddon [:gsnedders]
2021-04-14 11:12:45 PDT
Created attachment 426022 [details]
Patch
Somehow I totally missed the file (did I look in Tools or something equally silly?), and this is in fact used. Hmm. I wonder what to do here instead; having two different places where we store this metadata (especially within webkitpy's data model) is somewhat clumsy and annoying. (In reply to Sam Sneddon [:gsnedders] from comment #2) > Somehow I totally missed the file (did I look in Tools or something equally > silly?), and this is in fact used. Hmm. I wonder what to do here instead; > having two different places where we store this metadata (especially within > webkitpy's data model) is somewhat clumsy and annoying. Seems like all the effected tests are http tests....is there any reason we can't convert them to normal test expectations? Created attachment 429110 [details]
Patch
(In reply to Jonathan Bedard from comment #3) > (In reply to Sam Sneddon [:gsnedders] from comment #2) > > Somehow I totally missed the file (did I look in Tools or something equally > > silly?), and this is in fact used. Hmm. I wonder what to do here instead; > > having two different places where we store this metadata (especially within > > webkitpy's data model) is somewhat clumsy and annoying. > > Seems like all the effected tests are http tests....is there any reason we > can't convert them to normal test expectations? We could, though there was concern about bloating TestExpectations with WPT before. I think some of this is also related to the fact they'd need to be marked as slow in _every_ TestExpectations file, unless I'm misremembering how platform-specific expectations are added. That said, this new patch does a bunch of refactoring that we need to do anyway, and with that done it becomes pretty easy to support tests-options.json again. Committed r277781 (237942@main): <https://commits.webkit.org/237942@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 429110 [details]. |