Bug 161626 - Using tests-options.json to compute whether tests are slow
Summary: Using tests-options.json to compute whether tests are slow
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords:
Depends on: 161630
Blocks:
  Show dependency tree / graph
 
Reported: 2016-09-06 05:35 PDT by youenn fablet
Modified: 2021-04-14 11:12 PDT (History)
3 users (show)

See Also:

Attachments
Patch (5.09 KB, patch)
2016-09-06 05:43 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (6.03 KB, patch)
2016-09-07 01:19 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (6.02 KB, patch)
2016-09-07 01:25 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2016-09-06 05:35:07 PDT 
Let's extract the slow specific part of https://bugs.webkit.org/attachment.cgi?id=287954.
Comment 1 youenn fablet 2016-09-06 05:43:59 PDT 
Created attachment 288018 [details]
Patch
Comment 2 WebKit Commit Bot 2016-09-06 09:03:53 PDT 
Comment on attachment 288018 [details]
Patch

Clearing flags on attachment: 288018

Committed r205480: <http://trac.webkit.org/changeset/205480>
Comment 3 WebKit Commit Bot 2016-09-06 09:03:56 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 WebKit Commit Bot 2016-09-06 09:44:28 PDT 
Re-opened since this is blocked by bug 161630
Comment 5 youenn fablet 2016-09-07 01:19:50 PDT 
Created attachment 288119 [details]
Patch for landing
Comment 6 WebKit Commit Bot 2016-09-07 01:22:00 PDT 
Comment on attachment 288119 [details]
Patch for landing

Rejecting attachment 288119 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 288119, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in LayoutTests/ChangeLog contains OOPS!.

Full output: http://webkit-queues.webkit.org/results/2022888
Comment 7 youenn fablet 2016-09-07 01:25:43 PDT 
Created attachment 288120 [details]
Patch for landing
Comment 8 WebKit Commit Bot 2016-09-07 01:57:43 PDT 
Comment on attachment 288120 [details]
Patch for landing

Clearing flags on attachment: 288120

Committed r205539: <http://trac.webkit.org/changeset/205539>
Comment 9 WebKit Commit Bot 2016-09-07 01:57:46 PDT 
All reviewed patches have been landed.  Closing bug.