Bug 224557

Summary: [Nicosia] NicosiaGCGLLayer is unneeded when ENABLE_WEBGL is OFF
Product: WebKit Reporter: Don Olmstead <don.olmstead>
Component: PlatformAssignee: Don Olmstead <don.olmstead>
Status: RESOLVED FIXED    
Severity: Normal CC: mcatanzaro, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch ews-feeder: commit-queue-

Don Olmstead
Reported 2021-04-14 10:25:45 PDT
No GCGL means no need for a layer for it in Nicosia.
Attachments
Patch (1.81 KB, patch)
2021-04-14 10:28 PDT, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Patch (2.16 KB, patch)
2021-04-14 10:30 PDT, Don Olmstead 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Don Olmstead
Comment 1 2021-04-14 10:28:38 PDT Comment hidden (obsolete)
Don Olmstead
Comment 2 2021-04-14 10:30:02 PDT
Created attachment 426001 [details] Patch
Michael Catanzaro
Comment 3 2021-04-14 14:22:39 PDT
Comment on attachment 426001 [details] Patch No, EWS feeder, this commit did not break Mac EWS. Bad EWS feeder!
Don Olmstead
Comment 4 2021-04-14 18:57:37 PDT
(In reply to Michael Catanzaro from comment #3) > Comment on attachment 426001 [details] > Patch > > No, EWS feeder, this commit did not break Mac EWS. Bad EWS feeder! Trying again cause there’s no way this would break Mac
EWS
Comment 5 2021-04-14 20:50:59 PDT
Found 1 new test failure: imported/w3c/web-platform-tests/html/infrastructure/safe-passing-of-structured-data/messagechannel.any.html
Don Olmstead
Comment 6 2021-04-14 21:00:45 PDT
(In reply to EWS from comment #5) > Found 1 new test failure: > imported/w3c/web-platform-tests/html/infrastructure/safe-passing-of- > structured-data/messagechannel.any.html This patch is cursed....
EWS
Comment 7 2021-04-14 22:55:43 PDT
Committed r276001 (236553@main): <https://commits.webkit.org/236553@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 426001 [details].
Radar WebKit Bug Importer
Comment 8 2021-04-14 22:56:14 PDT
<rdar://problem/76686280>
Note You need to log in before you can comment on or make changes to this bug.