Bug 224557

Summary: [Nicosia] NicosiaGCGLLayer is unneeded when ENABLE_WEBGL is OFF
Product: WebKit Reporter: Don Olmstead <don.olmstead>
Component: PlatformAssignee: Don Olmstead <don.olmstead>
Status: RESOLVED FIXED    
Severity: Normal CC: mcatanzaro, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch ews-feeder: commit-queue-

Description Don Olmstead 2021-04-14 10:25:45 PDT 
No GCGL means no need for a layer for it in Nicosia.
Comment 1 Don Olmstead 2021-04-14 10:28:38 PDT Comment hidden (obsolete)
Comment 2 Don Olmstead 2021-04-14 10:30:02 PDT 
Created attachment 426001 [details]
Patch
Comment 3 Michael Catanzaro 2021-04-14 14:22:39 PDT 
Comment on attachment 426001 [details]
Patch

No, EWS feeder, this commit did not break Mac EWS. Bad EWS feeder!
Comment 4 Don Olmstead 2021-04-14 18:57:37 PDT 
(In reply to Michael Catanzaro from comment #3)
> Comment on attachment 426001 [details]
> Patch
> 
> No, EWS feeder, this commit did not break Mac EWS. Bad EWS feeder!

Trying again cause there’s no way this would break Mac
Comment 5 EWS 2021-04-14 20:50:59 PDT 
Found 1 new test failure: imported/w3c/web-platform-tests/html/infrastructure/safe-passing-of-structured-data/messagechannel.any.html
Comment 6 Don Olmstead 2021-04-14 21:00:45 PDT 
(In reply to EWS from comment #5)
> Found 1 new test failure:
> imported/w3c/web-platform-tests/html/infrastructure/safe-passing-of-
> structured-data/messagechannel.any.html

This patch is cursed....
Comment 7 EWS 2021-04-14 22:55:43 PDT 
Committed r276001 (236553@main): <https://commits.webkit.org/236553@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 426001 [details].
Comment 8 Radar WebKit Bug Importer 2021-04-14 22:56:14 PDT 
<rdar://problem/76686280>