Bug 224539

Summary: Remove a no longer necessary callOnMainThread in Worker::createRTCRtpScriptTransformer
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, eric.carlson, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Description youenn fablet 2021-04-14 03:54:35 PDT
Remove a no longer necessary callOnMainThread in Worker::createRTCRtpScriptTransformer
Comment 1 youenn fablet 2021-04-14 03:55:58 PDT
Created attachment 425968 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2021-04-15 01:43:37 PDT
<rdar://problem/76691688>
Comment 3 Darin Adler 2021-04-15 08:57:03 PDT
Comment on attachment 425968 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=425968&action=review

> Source/WebCore/ChangeLog:8
> +        No chnage of behavior.

Spelling error in "change" and I would just leave this out. (The important comment here is the one pointing to DestructionThread::Main below and anything else is a distraction.)
Comment 4 youenn fablet 2021-04-15 10:05:50 PDT
Created attachment 426114 [details]
Patch for landing
Comment 5 youenn fablet 2021-04-15 10:06:29 PDT
Thanks for the review.

(In reply to Darin Adler from comment #3)
> Comment on attachment 425968 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=425968&action=review
> 
> > Source/WebCore/ChangeLog:8
> > +        No chnage of behavior.
> 
> Spelling error in "change" and I would just leave this out. (The important
> comment here is the one pointing to DestructionThread::Main below and
> anything else is a distraction.)

Removed it.
Comment 6 EWS 2021-04-16 01:39:24 PDT
Committed r276124 (236620@main): <https://commits.webkit.org/236620@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 426114 [details].