Bug 224539 - Remove a no longer necessary callOnMainThread in Worker::createRTCRtpScriptTransformer
Summary: Remove a no longer necessary callOnMainThread in Worker::createRTCRtpScriptTr...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-04-14 03:54 PDT by youenn fablet
Modified: 2021-04-16 01:39 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.56 KB, patch)
2021-04-14 03:55 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (1.51 KB, patch)
2021-04-15 10:05 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2021-04-14 03:54:35 PDT 
Remove a no longer necessary callOnMainThread in Worker::createRTCRtpScriptTransformer
Comment 1 youenn fablet 2021-04-14 03:55:58 PDT 
Created attachment 425968 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2021-04-15 01:43:37 PDT 
<rdar://problem/76691688>
Comment 3 Darin Adler 2021-04-15 08:57:03 PDT 
Comment on attachment 425968 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=425968&action=review

> Source/WebCore/ChangeLog:8
> +        No chnage of behavior.

Spelling error in "change" and I would just leave this out. (The important comment here is the one pointing to DestructionThread::Main below and anything else is a distraction.)
Comment 4 youenn fablet 2021-04-15 10:05:50 PDT 
Created attachment 426114 [details]
Patch for landing
Comment 5 youenn fablet 2021-04-15 10:06:29 PDT 
Thanks for the review.

(In reply to Darin Adler from comment #3)
> Comment on attachment 425968 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=425968&action=review
> 
> > Source/WebCore/ChangeLog:8
> > +        No chnage of behavior.
> 
> Spelling error in "change" and I would just leave this out. (The important
> comment here is the one pointing to DestructionThread::Main below and
> anything else is a distraction.)

Removed it.
Comment 6 EWS 2021-04-16 01:39:24 PDT 
Committed r276124 (236620@main): <https://commits.webkit.org/236620@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 426114 [details].