Bug 224528

Summary: [LayoutTests] Convert http/tests/media convert PHP to Python
Product: WebKit Reporter: Chris Gambrell <cgambrell>
Component: Tools / TestsAssignee: Chris Gambrell <cgambrell>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, eric.carlson, ews-watchlist, glenn, hi, jbedard, jer.noble, philipj, ryanhaddad, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=220749
https://bugs.webkit.org/show_bug.cgi?id=224561
Attachments:
Description Flags
Patch
none
Patch jbedard: review+, ews-feeder: commit-queue-

Description Chris Gambrell 2021-04-13 22:05:44 PDT
Replacing PHP with equivalent Python CGI scripts
Comment 1 Radar WebKit Bug Importer 2021-04-13 22:06:15 PDT
<rdar://problem/76627995>
Comment 2 Chris Gambrell 2021-04-14 10:07:08 PDT
Created attachment 425996 [details]
Patch
Comment 3 Jonathan Bedard 2021-04-14 12:06:43 PDT
Comment on attachment 425996 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=425996&action=review

> LayoutTests/media/content/metadata.db:2
> +[

I think we should rename this file to 'metadata.json' to reflect it's actual content.
Comment 4 Chris Gambrell 2021-04-14 21:03:53 PDT
Created attachment 426073 [details]
Patch
Comment 5 Chris Gambrell 2021-04-14 21:04:12 PDT
(In reply to Jonathan Bedard from comment #3)
> Comment on attachment 425996 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=425996&action=review
> 
> > LayoutTests/media/content/metadata.db:2
> > +[
> 
> I think we should rename this file to 'metadata.json' to reflect it's actual
> content.

Fixed in comment 4
Comment 6 Chris Gambrell 2021-04-15 08:50:42 PDT
This is how CoreMedia is expected to behave and the Content-Length header will need to be specified.
Comment 7 Chris Gambrell 2021-04-15 08:51:34 PDT
Comment 6 and the state change was meant for https://bugs.webkit.org/show_bug.cgi?id=224339. Please disregard.
Comment 8 Jonathan Bedard 2021-04-15 08:56:33 PDT
Comment on attachment 426073 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=426073&action=review

> LayoutTests/http/tests/media/resources/create-id3-db.php:26
> +    // $ LayoutTests/media/content/metadata.json

Actually, you should keep this as metadata.db, since this file is going to dump PHP, not JSON.
Comment 9 Chris Gambrell 2021-04-15 09:02:35 PDT
Committed r276024 (236576@main): <https://commits.webkit.org/236576@main>