Bug 224511

Summary: Move cloneUBreakIterator declaration to IntlWorkaround.h
Product: WebKit Reporter: Ross Kirsling <ross.kirsling>
Component: New BugsAssignee: Ross Kirsling <ross.kirsling>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=224093
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Ross Kirsling
Reported 2021-04-13 14:41:48 PDT
Move cloneUBreakIterator declaration to IntlWorkaround.h
Attachments
Patch (7.96 KB, patch)
2021-04-13 14:44 PDT, Ross Kirsling 		no flags
DetailsFormatted DiffDiff
Patch (9.19 KB, patch)
2021-04-13 15:59 PDT, Ross Kirsling 		no flags
DetailsFormatted DiffDiff
Patch for landing (9.19 KB, patch)
2021-04-13 15:59 PDT, Ross Kirsling 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Ross Kirsling
Comment 1 2021-04-13 14:44:46 PDT
Created attachment 425915 [details] Patch
Yusuke Suzuki
Comment 2 2021-04-13 15:05:33 PDT
Comment on attachment 425915 [details] Patch r=me
Darin Adler
Comment 3 2021-04-13 15:05:47 PDT
Comment on attachment 425915 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=425915&action=review > Source/JavaScriptCore/runtime/IntlSegmenter.h:29 > +#include "IntlWorkaround.h" This include should be added to the two .cpp files that use it, not to a header. Also, don’t forget to remove the declaration of cloneUBreakIterator from this header. > Source/JavaScriptCore/runtime/IntlWorkaround.h:28 > +#include <unicode/utypes.h> It’s possible we could use a forward declaration for this too: typedef enum UErrorCode UErrorCode; But not an important optimization, so never mind.
Darin Adler
Comment 4 2021-04-13 15:26:19 PDT
Oops, bugs.webkit.org overwrite Yusuke's review flag with a darin? flag. Not intentional.
Ross Kirsling
Comment 5 2021-04-13 15:59:36 PDT Comment hidden (obsolete)
Ross Kirsling
Comment 6 2021-04-13 15:59:57 PDT
Created attachment 425926 [details] Patch for landing
Ross Kirsling
Comment 7 2021-04-13 16:04:56 PDT
(In reply to Darin Adler from comment #3) > > Source/JavaScriptCore/runtime/IntlWorkaround.h:28 > > +#include <unicode/utypes.h> > > It’s possible we could use a forward declaration for this too: > > typedef enum UErrorCode UErrorCode; > > But not an important optimization, so never mind. Yeah, I wanted to do so, but clang gave me "error: ISO C++ forbids forward references to 'enum' types".
EWS
Comment 8 2021-04-13 17:24:57 PDT
Committed r275920 (236483@main): <https://commits.webkit.org/236483@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 425926 [details].
Radar WebKit Bug Importer
Comment 9 2021-04-13 17:25:17 PDT
<rdar://problem/76618968>
Note You need to log in before you can comment on or make changes to this bug.