| Summary: | Move cloneUBreakIterator declaration to IntlWorkaround.h | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Ross Kirsling <ross.kirsling> | ||||||||
| Component: | New Bugs | Assignee: | Ross Kirsling <ross.kirsling> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | darin, ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer, ysuzuki | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=224093 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Ross Kirsling
2021-04-13 14:41:48 PDT
Created attachment 425915 [details]
Patch
Comment on attachment 425915 [details]
Patch
r=me
Comment on attachment 425915 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=425915&action=review > Source/JavaScriptCore/runtime/IntlSegmenter.h:29 > +#include "IntlWorkaround.h" This include should be added to the two .cpp files that use it, not to a header. Also, don’t forget to remove the declaration of cloneUBreakIterator from this header. > Source/JavaScriptCore/runtime/IntlWorkaround.h:28 > +#include <unicode/utypes.h> It’s possible we could use a forward declaration for this too: typedef enum UErrorCode UErrorCode; But not an important optimization, so never mind. Oops, bugs.webkit.org overwrite Yusuke's review flag with a darin? flag. Not intentional. Created attachment 425925 [details]
Patch
Created attachment 425926 [details]
Patch for landing
(In reply to Darin Adler from comment #3) > > Source/JavaScriptCore/runtime/IntlWorkaround.h:28 > > +#include <unicode/utypes.h> > > It’s possible we could use a forward declaration for this too: > > typedef enum UErrorCode UErrorCode; > > But not an important optimization, so never mind. Yeah, I wanted to do so, but clang gave me "error: ISO C++ forbids forward references to 'enum' types". Committed r275920 (236483@main): <https://commits.webkit.org/236483@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 425926 [details]. |