Bug 224501

Summary: [WebIDL] includes for `Conditional` dictionary members should also be guarded
Product: WebKit Reporter: Devin Rousso <hi>
Component: New BugsAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, darin, esprehn+autocc, ews-watchlist, heycam, hi, kondapallykalyan, rniwa, sam, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Devin Rousso
Reported 2021-04-13 12:21:18 PDT
right now only the usage of the member type is guarded inside `convertDictionary` the `#include` should also be guarded
Attachments
Patch (12.18 KB, patch)
2021-04-13 12:28 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2021-04-13 12:21:33 PDT
<rdar://problem/76598492>
Devin Rousso
Comment 2 2021-04-13 12:28:07 PDT
Created attachment 425898 [details] Patch
EWS
Comment 3 2021-04-13 13:38:09 PDT
Committed r275907 (236471@main): <https://commits.webkit.org/236471@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 425898 [details].
Note You need to log in before you can comment on or make changes to this bug.