Bug 224501 - [WebIDL] includes for `Conditional` dictionary members should also be guarded
Summary: [WebIDL] includes for `Conditional` dictionary members should also be guarded
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-04-13 12:21 PDT by Devin Rousso
Modified: 2021-04-13 13:38 PDT (History)
11 users (show)

See Also:

Attachments
Patch (12.18 KB, patch)
2021-04-13 12:28 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2021-04-13 12:21:18 PDT 
right now only the usage of the member type is guarded inside `convertDictionary`

the `#include` should also be guarded
Comment 1 Devin Rousso 2021-04-13 12:21:33 PDT 
<rdar://problem/76598492>
Comment 2 Devin Rousso 2021-04-13 12:28:07 PDT 
Created attachment 425898 [details]
Patch
Comment 3 EWS 2021-04-13 13:38:09 PDT 
Committed r275907 (236471@main): <https://commits.webkit.org/236471@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 425898 [details].