Bug 224497
| Summary: | [build.webkit.org] run-javascriptcore-tests should report commit identifier instead of svn revision to results.webkit.org | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Aakash Jain <aakash_jain> |
| Component: | Tools / Tests | Assignee: | Jonathan Bedard <jbedard> |
| Status: | ASSIGNED | ||
| Severity: | Normal | CC: | aakash_jain, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=222282 | ||
Aakash Jain
On build.webkit.org run-javascriptcore-tests should report commit identifier instead of svn revision to results.webkit.org.
Current logic seems to be finding the revision/hash using commitForDirectory() method in https://github.com/WebKit/WebKit/blob/main/Tools/Scripts/VCSUtils.pm#L382. We can update that logic to return commit identifier.
Other options are:
- run-javascriptcore-tests script can accept a parameter named commit-identifier/ref and buildbot can pass that parameter based on 'identifier' build property.
- do nothing, when we move build.webkit.org bots to git, run-javascriptcore-tests will start reporting git hash to results.webkit.org
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/76907517>