Bug 224494

Summary: The watchdog should not fire when it's not active.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, msaboff, saam, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch.
none
proposed patch.
none
proposed patch. saam: review+, ews-feeder: commit-queue-

Description Mark Lam 2021-04-13 11:12:26 PDT 
This is needed because JSValue::toWTFStringSlowCase() can throw exceptions and do many other VM operations.

rdar://76581259
Comment 1 Mark Lam 2021-04-13 11:16:23 PDT 
Created attachment 425886 [details]
proposed patch.
Comment 2 Mark Lam 2021-04-13 11:20:22 PDT 
Created attachment 425887 [details]
proposed patch.
Comment 3 Mark Lam 2021-04-13 14:57:09 PDT 
Created attachment 425919 [details]
proposed patch.
Comment 4 Yusuke Suzuki 2021-04-13 15:04:14 PDT 
Comment on attachment 425919 [details]
proposed patch.

r=me too.
Comment 5 Mark Lam 2021-04-13 19:17:08 PDT 
The mac-AS-debug-wk2 failure is unrelated.
Comment 6 Mark Lam 2021-04-13 19:20:14 PDT 
Thanks for the reviews.  Landed in r275924: <http://trac.webkit.org/r275924>.