Bug 224473

Summary: [JSC] Remove CodeBlock::m_constantsSourceCodeRepresentation
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch mark.lam: review+, ews-feeder: commit-queue-

Description Yusuke Suzuki 2021-04-12 22:40:17 PDT 
[JSC] Remove CodeBlock::m_constantsSourceCodeRepresentation
Comment 1 Yusuke Suzuki 2021-04-12 22:47:30 PDT 
Created attachment 425837 [details]
Patch
Comment 2 Mark Lam 2021-04-12 23:40:05 PDT 
Comment on attachment 425837 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=425837&action=review

r=me

> Source/JavaScriptCore/ChangeLog:13
> +        And it array is effectively accessed only when compiling DFG code. So we should remove copy of that in CodeBlock, and

/it array/the array/
Comment 3 Yusuke Suzuki 2021-04-13 00:02:16 PDT 
Comment on attachment 425837 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=425837&action=review

Thanks!

>> Source/JavaScriptCore/ChangeLog:13
>> +        And it array is effectively accessed only when compiling DFG code. So we should remove copy of that in CodeBlock, and
> 
> /it array/the array/

Fixed.
Comment 4 Yusuke Suzuki 2021-04-13 00:08:04 PDT 
inspector/canvas/shaderProgram-add-remove-webgpu.html is flaky (it was failing with the same kind of error).
Comment 5 Yusuke Suzuki 2021-04-13 00:35:47 PDT 
Committed r275866 (236431@main): <https://commits.webkit.org/236431@main>
Comment 6 Radar WebKit Bug Importer 2021-04-13 00:36:14 PDT 
<rdar://problem/76578949>
Comment 7 Yusuke Suzuki 2021-04-13 01:34:56 PDT 
Committed r275870 (236435@main): <https://commits.webkit.org/236435@main>