Bug 224451

Summary:

Remove support for NPAPI plugins in WKWebView

Product:

WebKit

Reporter:

Alex Christensen <achristensen>

Component:

New Bugs

Assignee:

Alex Christensen <achristensen>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=224441

Bug Depends on:

Bug Blocks:

224441

Attachments:

Description	Flags
Patch	none
Patch	none

Description Alex Christensen 2021-04-12 13:57:17 PDT

Remove support for NPAPI plugins in WKWebView

Comment 1 Alex Christensen 2021-04-12 14:12:45 PDT

Created attachment 425788 [details]
Patch

Comment 2 Chris Dumez 2021-04-12 14:39:07 PDT

Comment on attachment 425788 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=425788&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKPreferences.mm:-1520
> -    _preferences->setPluginsEnabled(plugInsEnabled);

I think we should add a RELEASE_LOG_FAULT() when this is called with plugInsEnabled. This should make issues way more obvious in the sysdiagnoses.

Comment 3 Alex Christensen 2021-04-12 14:53:29 PDT

Created attachment 425795 [details]
Patch

Comment 4 EWS 2021-04-13 14:18:35 PDT

Committed r275910 (236474@main): <https://commits.webkit.org/236474@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 425795 [details].

Comment 5 Radar WebKit Bug Importer 2021-04-13 14:19:14 PDT

<rdar://problem/76610110>