| Summary: | [JSC] Do not copy StringSwitchJumpTable | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Yusuke Suzuki <ysuzuki> | ||||
| Component: | New Bugs | Assignee: | Yusuke Suzuki <ysuzuki> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Yusuke Suzuki
2021-04-10 22:07:29 PDT
Created attachment 425699 [details]
Patch
My plan is doing the similar thing for SimpleJumpTable, but that was a bit more complicated. Comment on attachment 425699 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=425699&action=review r=me > Source/JavaScriptCore/ChangeLog:8 > + Previously, we are copying UnlinkedStringJumpTable to CodeBlock's StringJumpTable because we are embedding CodeLocation pointer Nit: Since previously is past tense the verb should be were rather than are. Also: "because we are embedding" => "because we embed" > Source/JavaScriptCore/ChangeLog:9 > + inside CodeBlock's StringJumpTable. This is copying mostly identical hashtable to each CodeBlock even in DFG and FTL. And this Nit: "copying mostly" => "copying a mostly". You can also drop the "and in the third sentence. > Source/JavaScriptCore/ChangeLog:10 > + even prevents us from inlining op_switch_string in DFG and FTL. Maybe explain why it prevents inlining. > Source/JavaScriptCore/ChangeLog:15 > + from copying unnecessary hashtable, and even this paves the way to inlining switch_string in DFG and FTL. Nit: hashtables* Committed r275840 (236408@main): <https://commits.webkit.org/236408@main> |