| Summary: | webaudio/AudioListener/audiolistener-set-position.html is leaking PannerNodes | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||
| Component: | Web Audio | Assignee: | Chris Dumez <cdumez> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | cdumez, darin, eric.carlson, ews-watchlist, ggaren, glenn, jer.noble, peng.liu6, philipj, sergio, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=224387 | ||||||||
| Attachments: |
|
||||||||
|
Description
Chris Dumez
2021-04-09 16:30:07 PDT
*** Bug 224439 has been marked as a duplicate of this bug. *** Created attachment 425771 [details]
Patch
Created attachment 425774 [details]
Patch
Comment on attachment 425774 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=425774&action=review r=me > Source/WebCore/ChangeLog:33 > + Early return if lazyInitialize() gets called for au audiocontext is closed. Nothing prevents JS from for au => after an > Source/WebCore/Modules/webaudio/AudioScheduledSourceNode.cpp:184 > +bool AudioScheduledSourceNode::virtualHasPendingActivity() const Not for this patch, but this function really needs a better to name to clarify that it is an addition, *not* an override. Maybe "hasAdditionalPendingActivity" or something like that. Committed r275838 (236406@main): <https://commits.webkit.org/236406@main> |