Bug 224394

Summary: scrollingTreeNodeDidScroll() should just trigger a rendering udpate
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: ScrollingAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: alex, cmarcelo, ews-watchlist, fred.wang, jamesr, luiz, simon.fraser, thorton, tonikitoo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch ews-feeder: commit-queue-

Simon Fraser (smfr)
Reported 2021-04-09 15:05:29 PDT
scrollingTreeNodeDidScroll() should just trigger a rendering udpate
Attachments
Patch (6.90 KB, patch)
2021-04-09 15:47 PDT, Simon Fraser (smfr) 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2021-04-09 15:47:46 PDT
Created attachment 425660 [details] Patch
EWS
Comment 2 2021-04-09 19:11:09 PDT
Committed r275790 (236361@main): <https://commits.webkit.org/236361@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 425660 [details].
Radar WebKit Bug Importer
Comment 3 2021-04-09 19:16:05 PDT
<rdar://problem/76481198>
Alejandro G. Castro
Comment 4 2021-04-15 04:05:56 PDT
This patch broke the async scrolling for gtk and wpe, we do not have the call to synchronizeStateFromScrollingTree in Nicosia implementation. I could fix adding a willStartRenderingUpdate implementation to Nicosia that syncs but I'll take this failure as an opportunitty to review the whole synchronization because maybe we have other differences that can cause trouble in the future.
Alejandro G. Castro
Comment 5 2021-04-20 12:45:42 PDT
Created bug 224824 to solve the regression in WPE and GTK.
Note You need to log in before you can comment on or make changes to this bug.