Bug 224379

Summary:

WTF SoftLinking macros can cause collisions with their target functions

Product:

WebKit

Reporter:

Jer Noble <jer.noble>

Component:

New Bugs

Assignee:

Jer Noble <jer.noble>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, benjamin, cdumez, cmarcelo, ddkilzer, eric.carlson, ews-watchlist, glenn, peng.liu6, philipj, sergio, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	ews-feeder: commit-queue-
Patch	none

Description Jer Noble 2021-04-09 11:12:25 PDT

WTF SoftLinking macros can cause collisions with their target functions

Comment 1 Jer Noble 2021-04-09 11:14:18 PDT

<rdar://76434202>

Comment 2 Jer Noble 2021-04-09 11:19:22 PDT

Created attachment 425635 [details]
Patch

Comment 3 Jer Noble 2021-04-09 11:28:33 PDT

Created attachment 425637 [details]
Patch

Comment 4 Eric Carlson 2021-04-09 13:22:08 PDT

Comment on attachment 425637 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=425637&action=review

> Source/WebCore/xml/SoftLinkLibxslt.h:27
> +

Nit: extra blank line

Comment 5 Jer Noble 2021-04-09 13:32:01 PDT

Comment on attachment 425637 [details]
Patch

Clearing flags on attachment: 425637

Committed r275775 (236350@main): <https://commits.webkit.org/236350@main>

Comment 6 Jer Noble 2021-04-09 13:32:04 PDT

All reviewed patches have been landed.  Closing bug.