Bug 224364

Summary: Change WebXRSpace::efectiveOrigin() matrix multiplication order
Product: WebKit Reporter: Imanol Fernandez <ifernandez>
Component: WebXRAssignee: Imanol Fernandez <ifernandez>
Status: RESOLVED FIXED    
Severity: Normal CC: svillar, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 208988    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch for landing none

Description Imanol Fernandez 2021-04-09 04:31:46 PDT 
The current multiplication order is not working correctly when combining local-floor space and getOfffsetReferenceSpace(). The reference space is out of sync with input ray pose after some teleportations (tested using https://github.com/immersive-web/webxr-samples/blob/main/teleportation.html).

There is a WPT test to reproduce this but we can't enable it yet until we fetch it from upstream (https://github.com/web-platform-tests/wpt/pull/28024), currently blocked by WebGL 2 support in WPE.
Comment 1 Imanol Fernandez 2021-04-09 04:46:07 PDT 
Created attachment 425608 [details]
Patch
Comment 2 Sergio Villar Senin 2021-04-09 07:55:28 PDT 
Comment on attachment 425608 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=425608&action=review

> Source/WebCore/ChangeLog:8
> +        The current multiplication order is not working correctly when combining local-floor space and getOfffsetReferenceSpace().

Nit: Offfset -> Offset

> Source/WebCore/ChangeLog:12
> +        currently blocked by WebGL 2 support in WPE.

WebGL2 shouldn't be a blocker for the testing of this kind of stuff. Why don't we just add a new small test to WPT to check this?
Comment 3 Radar WebKit Bug Importer 2021-04-16 04:32:14 PDT 
<rdar://problem/76754680>
Comment 4 Imanol Fernandez 2021-06-07 05:41:41 PDT 
Created attachment 430737 [details]
Patch

Rebase onto main
Comment 5 Imanol Fernandez 2021-06-07 06:11:49 PDT 
Created attachment 430739 [details]
Patch

Add missing rdar item to the changelog
Comment 6 Sergio Villar Senin 2021-06-07 07:00:10 PDT 
Comment on attachment 430739 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=430739&action=review

> Source/WebCore/ChangeLog:10
> +        The reference space is out of sync with input ray pose after some teleportations (https://github.com/immersive-web/webxr-samples/blob/main/teleportation.html).

Nit: move the URL to the next line.
Comment 7 Imanol Fernandez 2021-06-07 08:23:33 PDT 
Created attachment 430747 [details]
Patch

Fix nit in the changelog
Comment 8 Imanol Fernandez 2021-06-07 08:26:28 PDT 
Created attachment 430748 [details]
Patch for landing
Comment 9 EWS 2021-06-07 10:00:38 PDT 
Committed r278563 (238561@main): <https://commits.webkit.org/238561@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 430748 [details].