Bug 224364 – Change WebXRSpace::efectiveOrigin() matrix multiplication order

• Status: RESOLVED
• Resolution: FIXED
• Component: WebXR

[Imanol Fernandez]

The current multiplication order is not working correctly when combining local-floor space and getOfffsetReferenceSpace(). The reference space is out of sync with input ray pose after some teleportations (tested using https://github.com/immersive-web/webxr-samples/blob/main/teleportation.html).

There is a WPT test to reproduce this but we can't enable it yet until we fetch it from upstream (https://github.com/web-platform-tests/wpt/pull/28024), currently blocked by WebGL 2 support in WPE.

[Imanol Fernandez]

Created attachment 425608 [details]
Patch

[Sergio Villar Senin]

Comment on attachment 425608 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=425608&action=review

> Source/WebCore/ChangeLog:8
> +        The current multiplication order is not working correctly when combining local-floor space and getOfffsetReferenceSpace().

Nit: Offfset -> Offset

> Source/WebCore/ChangeLog:12
> +        currently blocked by WebGL 2 support in WPE.

WebGL2 shouldn't be a blocker for the testing of this kind of stuff. Why don't we just add a new small test to WPT to check this?

[Radar WebKit Bug Importer]

<rdar://problem/76754680>

[Imanol Fernandez]

Created attachment 430737 [details]
Patch

Rebase onto main

[Imanol Fernandez]

Created attachment 430739 [details]
Patch

Add missing rdar item to the changelog

[Sergio Villar Senin]

Comment on attachment 430739 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=430739&action=review

> Source/WebCore/ChangeLog:10
> +        The reference space is out of sync with input ray pose after some teleportations (https://github.com/immersive-web/webxr-samples/blob/main/teleportation.html).

Nit: move the URL to the next line.

[Imanol Fernandez]

Created attachment 430747 [details]
Patch

Fix nit in the changelog

[Imanol Fernandez]

Created attachment 430748 [details]
Patch for landing

[EWS]

Committed r278563 (238561@main): <https://commits.webkit.org/238561@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 430748 [details].