Bug 224364 - Change WebXRSpace::efectiveOrigin() matrix multiplication order
Summary: Change WebXRSpace::efectiveOrigin() matrix multiplication order
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebXR (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Imanol Fernandez
URL:
Keywords: InRadar
Depends on:
Blocks: 208988
  Show dependency treegraph
 
Reported: 2021-04-09 04:31 PDT by Imanol Fernandez
Modified: 2021-04-16 04:32 PDT (History)
2 users (show)

See Also:


Attachments
Patch (1.95 KB, patch)
2021-04-09 04:46 PDT, Imanol Fernandez
ifernandez: review?
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Imanol Fernandez 2021-04-09 04:31:46 PDT
The current multiplication order is not working correctly when combining local-floor space and getOfffsetReferenceSpace(). The reference space is out of sync with input ray pose after some teleportations (tested using https://github.com/immersive-web/webxr-samples/blob/main/teleportation.html).

There is a WPT test to reproduce this but we can't enable it yet until we fetch it from upstream (https://github.com/web-platform-tests/wpt/pull/28024), currently blocked by WebGL 2 support in WPE.
Comment 1 Imanol Fernandez 2021-04-09 04:46:07 PDT
Created attachment 425608 [details]
Patch
Comment 2 Sergio Villar Senin 2021-04-09 07:55:28 PDT
Comment on attachment 425608 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=425608&action=review

> Source/WebCore/ChangeLog:8
> +        The current multiplication order is not working correctly when combining local-floor space and getOfffsetReferenceSpace().

Nit: Offfset -> Offset

> Source/WebCore/ChangeLog:12
> +        currently blocked by WebGL 2 support in WPE.

WebGL2 shouldn't be a blocker for the testing of this kind of stuff. Why don't we just add a new small test to WPT to check this?
Comment 3 Radar WebKit Bug Importer 2021-04-16 04:32:14 PDT
<rdar://problem/76754680>