Bug 224351

Summary:

Safari unit tests sometimes fail an ASSERTion in IOSurface.mm's optionsFor32BitSurface()

Product:

WebKit

Reporter:

Tim Horton <thorton>

Component:

New Bugs

Assignee:

Tim Horton <thorton>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

simon.fraser, webkit-bug-importer, wenson_hsieh

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Description Tim Horton 2021-04-08 17:46:30 PDT

Safari unit tests sometimes fail an ASSERTion in IOSurface.mm's optionsFor32BitSurface()

Comment 1 Tim Horton 2021-04-08 17:46:49 PDT

Created attachment 425565 [details]
Patch

Comment 2 Tim Horton 2021-04-08 17:46:52 PDT

<rdar://problem/76405354>

Comment 3 Wenson Hsieh 2021-04-08 18:00:25 PDT

Comment on attachment 425565 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=425565&action=review

> Source/WebCore/platform/graphics/cocoa/IOSurface.mm:209
> +    ASSERT(size.width());
> +    ASSERT(size.height());

Nit - perhaps just `ASSERT(!size.isEmpty());` would be cleaner?

Comment 4 Tim Horton 2021-04-08 18:06:58 PDT

(In reply to Wenson Hsieh from comment #3)
> Comment on attachment 425565 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=425565&action=review
> 
> > Source/WebCore/platform/graphics/cocoa/IOSurface.mm:209
> > +    ASSERT(size.width());
> > +    ASSERT(size.height());
> 
> Nit - perhaps just `ASSERT(!size.isEmpty());` would be cleaner?

Sure, that ... seems like the obvious thing to do, in hindsight.

Comment 5 Tim Horton 2021-04-08 18:16:07 PDT

Created attachment 425566 [details]
Patch

Comment 6 EWS 2021-04-08 18:49:09 PDT

Committed r275737 (236324@main): <https://commits.webkit.org/236324@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 425566 [details].