Bug 224332

Summary: Remove virtual from RenderBox::availableLogicalWidth
Product: WebKit Reporter: Rob Buis <rbuis>
Component: CSSAssignee: Rob Buis <rbuis>
Status: RESOLVED FIXED    
Severity: Normal CC: changseok, darin, esprehn+autocc, ews-watchlist, glenn, kondapallykalyan, pdr, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Rob Buis
Reported 2021-04-08 11:45:18 PDT
Remove virtual from RenderBox::availableLogicalWidth since it is not overwritten.
Attachments
Patch (1.48 KB, patch)
2021-04-08 11:46 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (1.47 KB, patch)
2021-04-08 12:56 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Rob Buis
Comment 1 2021-04-08 11:46:26 PDT
Created attachment 425526 [details] Patch
Darin Adler
Comment 2 2021-04-08 12:50:32 PDT
Comment on attachment 425526 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=425526&action=review > Source/WebCore/ChangeLog:9 > + it is not overwritten. overwritten -> overridden
Rob Buis
Comment 3 2021-04-08 12:53:39 PDT
Comment on attachment 425526 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=425526&action=review >> Source/WebCore/ChangeLog:9 >> + it is not overwritten. > > overwritten -> overridden Thanks, was doing too many things at once. I think for mistakes like this it would be nice to be able to edit the commit message and spare the re-upload.
Rob Buis
Comment 4 2021-04-08 12:56:24 PDT
Created attachment 425535 [details] Patch
EWS
Comment 5 2021-04-08 13:46:29 PDT
Committed r275675 (236311@main): <https://commits.webkit.org/236311@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 425535 [details].
Radar WebKit Bug Importer
Comment 6 2021-04-08 13:47:13 PDT
<rdar://problem/76419632>
Note You need to log in before you can comment on or make changes to this bug.