Bug 224312

Summary: Bugzilla needs to linkify identifiers
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, dewei_zhu, lingho, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Jonathan Bedard
Reported 2021-04-07 16:43:45 PDT
Bugzilla linkifies revisions, but not identifiers.
Attachments
Patch (6.81 KB, patch)
2021-04-07 16:53 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (9.31 KB, patch)
2021-04-23 16:31 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (2.25 KB, patch)
2021-04-26 11:05 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Jonathan Bedard
Comment 1 2021-04-07 16:47:55 PDT
<rdar://problem/75845629>
Jonathan Bedard
Comment 2 2021-04-07 16:53:46 PDT
Created attachment 425455 [details] Patch
Jonathan Bedard
Comment 3 2021-04-07 16:56:09 PDT
(In reply to Jonathan Bedard from comment #2) > Created attachment 425455 [details] > Patch I'm intend to include this change in the same extension used to linkify revisions. First step is to rename the extension.
Alexey Proskuryakov
Comment 4 2021-04-08 07:05:32 PDT
*** Bug 224325 has been marked as a duplicate of this bug. ***
Jonathan Bedard
Comment 5 2021-04-23 16:31:45 PDT
Created attachment 426964 [details] Patch
dewei_zhu
Comment 6 2021-04-23 16:43:48 PDT
Comment on attachment 426964 [details] Patch r=me
EWS
Comment 7 2021-04-23 17:18:38 PDT
Committed r276536 (236983@main): <https://commits.webkit.org/236983@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 426964 [details].
Jonathan Bedard
Comment 8 2021-04-26 11:05:09 PDT
Reopening to attach new patch.
Jonathan Bedard
Comment 9 2021-04-26 11:05:10 PDT
Created attachment 427062 [details] Patch
Aakash Jain
Comment 10 2021-04-27 08:25:34 PDT
Comment on attachment 427062 [details] Patch rs=me Is the linking to commits.webkit.org long-term solution, or after we move to github, we should link directly to github instead of using one translation layer in between?
Jonathan Bedard
Comment 11 2021-04-27 08:30:52 PDT
(In reply to Aakash Jain from comment #10) > Comment on attachment 427062 [details] > Patch > > rs=me > > Is the linking to commits.webkit.org long-term solution, or after we move to > github, we should link directly to github instead of using one translation > layer in between? That's our long-term solution, because we don't expect that GitHub will ever support identifiers natively.
EWS
Comment 12 2021-04-27 08:34:53 PDT
Committed r276640 (237068@main): <https://commits.webkit.org/237068@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 427062 [details].
Jonathan Bedard
Comment 13 2021-04-27 09:50:06 PDT
Deployed this to bugs.webkit.org
Note You need to log in before you can comment on or make changes to this bug.