Bug 22430

Summary: Only the first WML <card> element should be visible.
Product: WebKit Reporter: Nikolas Zimmermann <zimmermann>
Component: XMLAssignee: Nikolas Zimmermann <zimmermann>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 20393    
Attachments:
Description Flags
LayoutTest changes
staikos: review+
Initial patch staikos: review+

Nikolas Zimmermann
Reported 2008-11-22 14:21:37 PST
As the summary says, only the first <card> element in a WML document should be visible. All other card elements are only reachable with a <go> statement within the WML document.
Attachments
LayoutTest changes (18.39 KB, patch)
2008-11-22 14:28 PST, Nikolas Zimmermann
staikos: review+
Initial patch (6.48 KB, patch)
2008-11-22 14:29 PST, Nikolas Zimmermann
staikos: review+
Nikolas Zimmermann
Comment 1 2008-11-22 14:28:57 PST
Created attachment 25381 [details] LayoutTest changes
Nikolas Zimmermann
Comment 2 2008-11-22 14:29:17 PST
Created attachment 25382 [details] Initial patch
Eric Seidel (no email)
Comment 3 2008-11-24 12:48:32 PST
This seems lame: 53 if (!page->wmlPageState()->isDeckAccessible()) { 54 page->goBack(); 55 return; 56 } Does this mean that a user will click on a link, will be taken to a different "card" or "deck" and then suddenly their browser will go back w/ no explanation?
Nikolas Zimmermann
Comment 4 2008-11-24 13:10:24 PST
(In reply to comment #3) > This seems lame: > 53 if (!page->wmlPageState()->isDeckAccessible()) { > 54 page->goBack(); > 55 return; > 56 } > > Does this mean that a user will click on a link, will be taken to a different > "card" or "deck" and then suddenly their browser will go back w/ no > explanation? Fixed, I bet this is a testing leftover. just replaced by // FIXME: Error reporting. >
Nikolas Zimmermann
Comment 5 2008-11-24 16:23:37 PST
Landed in r38736.
Note You need to log in before you can comment on or make changes to this bug.