Bug 224295

Summary: Rename and make the TerminationException a singleton.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, calvaris, ews-watchlist, hi, joepeck, keith_miller, mkwst, msaboff, saam, tzagallo, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch.
ews-feeder: commit-queue-
proposed patch. none

Description Mark Lam 2021-04-07 11:11:54 PDT 
We previously call it the TerminatedExecutionException, which is a mouthful but adds no meaningful information.

We can make it a singleton because the TerminationException is just a VM internal mechanism for implementing the termination of the current execution stack.  It should never be exposed to user JS code, and therefore, there is no value in making it a JS object.  Making it a singleton simplifies the code.
Comment 1 Mark Lam 2021-04-07 12:24:04 PDT 
Created attachment 425424 [details]
proposed patch.
Comment 2 Mark Lam 2021-04-07 12:52:40 PDT 
Created attachment 425429 [details]
proposed patch.
Comment 3 Keith Miller 2021-04-07 15:12:16 PDT 
Comment on attachment 425429 [details]
proposed patch.

r=me the iOS-wk2 failures seem unrelated but maybe worth waiting for confirmation.
Comment 4 Mark Lam 2021-04-07 17:05:44 PDT 
Comment on attachment 425429 [details]
proposed patch.

Thanks for the review.  Landing now.
Comment 5 EWS 2021-04-07 17:30:21 PDT 
Committed r275648: <https://commits.webkit.org/r275648>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 425429 [details].
Comment 6 Radar WebKit Bug Importer 2021-04-07 17:31:16 PDT 
<rdar://problem/76373832>